diff options
Diffstat (limited to 'fs/nfsd/nfs4state.c')
-rw-r--r-- | fs/nfsd/nfs4state.c | 28 |
1 files changed, 13 insertions, 15 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 70cba3fbfa6..e2b11b1b515 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c | |||
@@ -414,31 +414,31 @@ gen_sessionid(struct nfsd4_session *ses) | |||
414 | 414 | ||
415 | /* | 415 | /* |
416 | * Give the client the number of slots it requests bound by | 416 | * Give the client the number of slots it requests bound by |
417 | * NFSD_MAX_SLOTS_PER_SESSION and by sv_drc_max_pages. | 417 | * NFSD_MAX_SLOTS_PER_SESSION and by nfsd_drc_max_mem. |
418 | * | 418 | * |
419 | * If we run out of pages (sv_drc_pages_used == sv_drc_max_pages) we | 419 | * If we run out of reserved DRC memory we should (up to a point) re-negotiate |
420 | * should (up to a point) re-negotiate active sessions and reduce their | 420 | * active sessions and reduce their slot usage to make rooom for new |
421 | * slot usage to make rooom for new connections. For now we just fail the | 421 | * connections. For now we just fail the create session. |
422 | * create session. | ||
423 | */ | 422 | */ |
424 | static int set_forechannel_maxreqs(struct nfsd4_channel_attrs *fchan) | 423 | static int set_forechannel_maxreqs(struct nfsd4_channel_attrs *fchan) |
425 | { | 424 | { |
426 | int np; | 425 | int mem; |
427 | 426 | ||
428 | if (fchan->maxreqs < 1) | 427 | if (fchan->maxreqs < 1) |
429 | return nfserr_inval; | 428 | return nfserr_inval; |
430 | else if (fchan->maxreqs > NFSD_MAX_SLOTS_PER_SESSION) | 429 | else if (fchan->maxreqs > NFSD_MAX_SLOTS_PER_SESSION) |
431 | fchan->maxreqs = NFSD_MAX_SLOTS_PER_SESSION; | 430 | fchan->maxreqs = NFSD_MAX_SLOTS_PER_SESSION; |
432 | 431 | ||
433 | np = fchan->maxreqs * NFSD_PAGES_PER_SLOT; | 432 | mem = fchan->maxreqs * NFSD_SLOT_CACHE_SIZE; |
434 | 433 | ||
435 | spin_lock(&nfsd_drc_lock); | 434 | spin_lock(&nfsd_drc_lock); |
436 | if (np + nfsd_drc_pages_used > nfsd_drc_max_pages) | 435 | if (mem + nfsd_drc_mem_used > nfsd_drc_max_mem) |
437 | np = nfsd_drc_max_pages - nfsd_drc_pages_used; | 436 | mem = ((nfsd_drc_max_mem - nfsd_drc_mem_used) / |
438 | nfsd_drc_pages_used += np; | 437 | NFSD_SLOT_CACHE_SIZE) * NFSD_SLOT_CACHE_SIZE; |
438 | nfsd_drc_mem_used += mem; | ||
439 | spin_unlock(&nfsd_drc_lock); | 439 | spin_unlock(&nfsd_drc_lock); |
440 | 440 | ||
441 | fchan->maxreqs = np / NFSD_PAGES_PER_SLOT; | 441 | fchan->maxreqs = mem / NFSD_SLOT_CACHE_SIZE; |
442 | if (fchan->maxreqs == 0) | 442 | if (fchan->maxreqs == 0) |
443 | return nfserr_resource; | 443 | return nfserr_resource; |
444 | return 0; | 444 | return 0; |
@@ -465,9 +465,7 @@ static int init_forechannel_attrs(struct svc_rqst *rqstp, | |||
465 | fchan->maxresp_sz = maxcount; | 465 | fchan->maxresp_sz = maxcount; |
466 | session_fchan->maxresp_sz = fchan->maxresp_sz; | 466 | session_fchan->maxresp_sz = fchan->maxresp_sz; |
467 | 467 | ||
468 | /* Set the max response cached size our default which is | 468 | session_fchan->maxresp_cached = NFSD_SLOT_CACHE_SIZE; |
469 | * a multiple of PAGE_SIZE and small */ | ||
470 | session_fchan->maxresp_cached = NFSD_PAGES_PER_SLOT * PAGE_SIZE; | ||
471 | fchan->maxresp_cached = session_fchan->maxresp_cached; | 469 | fchan->maxresp_cached = session_fchan->maxresp_cached; |
472 | 470 | ||
473 | /* Use the client's maxops if possible */ | 471 | /* Use the client's maxops if possible */ |
@@ -585,7 +583,7 @@ free_session(struct kref *kref) | |||
585 | nfsd4_release_respages(e->ce_respages, e->ce_resused); | 583 | nfsd4_release_respages(e->ce_respages, e->ce_resused); |
586 | } | 584 | } |
587 | spin_lock(&nfsd_drc_lock); | 585 | spin_lock(&nfsd_drc_lock); |
588 | nfsd_drc_pages_used -= ses->se_fchannel.maxreqs * NFSD_PAGES_PER_SLOT; | 586 | nfsd_drc_mem_used -= ses->se_fchannel.maxreqs * NFSD_SLOT_CACHE_SIZE; |
589 | spin_unlock(&nfsd_drc_lock); | 587 | spin_unlock(&nfsd_drc_lock); |
590 | kfree(ses); | 588 | kfree(ses); |
591 | } | 589 | } |