8 files changed, 301 insertions, 168 deletions

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index ec4faffe6b0..f526e735c5a 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -231,8 +231,36 @@ config THINKPAD_ACPI
 
           This driver was formerly known as ibm-acpi.
 
+          Extra functionality will be available if the rfkill (CONFIG_RFKILL)
+          and/or ALSA (CONFIG_SND) subsystems are available in the kernel.
+          Note that if you want ThinkPad-ACPI to be built-in instead of
+          modular, ALSA and rfkill will also have to be built-in.
+
           If you have an IBM or Lenovo ThinkPad laptop, say Y or M here.
 
+config THINKPAD_ACPI_ALSA_SUPPORT
+        bool "Console audio control ALSA interface"
+        depends on THINKPAD_ACPI
+        depends on SND
+        depends on SND = y || THINKPAD_ACPI = SND
+        default y
+        ---help---
+          Enables monitoring of the built-in console audio output control
+          (headphone and speakers), which is operated by the mute and (in
+          some ThinkPad models) volume hotkeys.
+
+          If this option is enabled, ThinkPad-ACPI will export an ALSA card
+          with a single read-only mixer control, which should be used for
+          on-screen-display feedback purposes by the Desktop Environment.
+
+          Optionally, the driver will also allow software control (the
+          ALSA mixer will be made read-write).  Please refer to the driver
+          documentation for details.
+
+          All IBM models have both volume and mute control.  Newer Lenovo
+          models only have mute control (the volume hotkeys are just normal
+          keys and volume control is done through the main HDA mixer).
+
 config THINKPAD_ACPI_DEBUGFACILITIES
         bool "Maintainer debug facilities"
         depends on THINKPAD_ACPI
@@ -336,6 +364,7 @@ config EEEPC_LAPTOP
         select HWMON
         select LEDS_CLASS
         select NEW_LEDS
+        select INPUT_SPARSEKMAP
         ---help---
           This driver supports the Fn-Fx keys on Eee PC laptops.
 
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 916ccb2b316..1b1dddbd574 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -202,8 +202,13 @@ static void dell_wmi_notify(u32 value, void *context)
         struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
         static struct key_entry *key;
         union acpi_object *obj;
+        acpi_status status;
 
-        wmi_get_event_data(value, &response);
+        status = wmi_get_event_data(value, &response);
+        if (status != AE_OK) {
+                printk(KERN_INFO "dell-wmi: bad event status 0x%x\n", status);
+                return;
+        }
 
         obj = (union acpi_object *)response.pointer;
 
@@ -323,8 +328,9 @@ static int __init dell_wmi_input_setup(void)
 static int __init dell_wmi_init(void)
 {
         int err;
+        acpi_status status;
 
-        if (wmi_has_guid(DELL_EVENT_GUID)) {
+        if (!wmi_has_guid(DELL_EVENT_GUID)) {
                 printk(KERN_WARNING "dell-wmi: No known WMI GUID found\n");
                 return -ENODEV;
         }
@@ -336,14 +342,14 @@ static int __init dell_wmi_init(void)
         if (err)
                 return err;
 
-        err = wmi_install_notify_handler(DELL_EVENT_GUID,
+        status = wmi_install_notify_handler(DELL_EVENT_GUID,
                                          dell_wmi_notify, NULL);
-        if (err) {
+        if (ACPI_FAILURE(status)) {
                 input_unregister_device(dell_wmi_input_dev);
                 printk(KERN_ERR
                         "dell-wmi: Unable to register notify handler - %d\n",
-                        err);
-                return err;
+                        status);
+                return -ENODEV;
         }
 
         return 0;
diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
index 5838c69b2fb..e2be6bb33d9 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers/platform/x86/eeepc-laptop.c
@@ -31,10 +31,12 @@
 #include <acpi/acpi_bus.h>
 #include <linux/uaccess.h>
 #include <linux/input.h>
+#include <linux/input/sparse-keymap.h>
 #include <linux/rfkill.h>
 #include <linux/pci.h>
 #include <linux/pci_hotplug.h>
 #include <linux/leds.h>
+#include <linux/dmi.h>
 
 #define EEEPC_LAPTOP_VERSION    "0.1"
 #define EEEPC_LAPTOP_NAME       "Eee PC Hotkey Driver"
@@ -48,6 +50,14 @@ MODULE_AUTHOR("Corentin Chary, Eric Cooper");
 MODULE_DESCRIPTION(EEEPC_LAPTOP_NAME);
 MODULE_LICENSE("GPL");
 
+static bool hotplug_disabled;
+
+module_param(hotplug_disabled, bool, 0644);
+MODULE_PARM_DESC(hotplug_disabled,
+                 "Disable hotplug for wireless device. "
+                 "If your laptop need that, please report to "
+                 "acpi4asus-user@lists.sourceforge.net.");
+
 /*
  * Definitions for Asus EeePC
  */
@@ -120,38 +130,28 @@ static const char *cm_setv[] = {
         NULL, NULL, "PBPS", "TPDS"
 };
 
-struct key_entry {
-        char type;
-        u8 code;
-        u16 keycode;
-};
-
-enum { KE_KEY, KE_END };
-
 static const struct key_entry eeepc_keymap[] = {
-        /* Sleep already handled via generic ACPI code */
-        {KE_KEY, 0x10, KEY_WLAN },
-        {KE_KEY, 0x11, KEY_WLAN },
-        {KE_KEY, 0x12, KEY_PROG1 },
-        {KE_KEY, 0x13, KEY_MUTE },
-        {KE_KEY, 0x14, KEY_VOLUMEDOWN },
-        {KE_KEY, 0x15, KEY_VOLUMEUP },
-        {KE_KEY, 0x16, KEY_DISPLAY_OFF },
-        {KE_KEY, 0x1a, KEY_COFFEE },
-        {KE_KEY, 0x1b, KEY_ZOOM },
-        {KE_KEY, 0x1c, KEY_PROG2 },
-        {KE_KEY, 0x1d, KEY_PROG3 },
-        {KE_KEY, NOTIFY_BRN_MIN, KEY_BRIGHTNESSDOWN },
-        {KE_KEY, NOTIFY_BRN_MAX, KEY_BRIGHTNESSUP },
-        {KE_KEY, 0x30, KEY_SWITCHVIDEOMODE },
-        {KE_KEY, 0x31, KEY_SWITCHVIDEOMODE },
-        {KE_KEY, 0x32, KEY_SWITCHVIDEOMODE },
-        {KE_KEY, 0x37, KEY_F13 }, /* Disable Touchpad */
-        {KE_KEY, 0x38, KEY_F14 },
-        {KE_END, 0},
+        { KE_KEY, 0x10, { KEY_WLAN } },
+        { KE_KEY, 0x11, { KEY_WLAN } },
+        { KE_KEY, 0x12, { KEY_PROG1 } },
+        { KE_KEY, 0x13, { KEY_MUTE } },
+        { KE_KEY, 0x14, { KEY_VOLUMEDOWN } },
+        { KE_KEY, 0x15, { KEY_VOLUMEUP } },
+        { KE_KEY, 0x16, { KEY_DISPLAY_OFF } },
+        { KE_KEY, 0x1a, { KEY_COFFEE } },
+        { KE_KEY, 0x1b, { KEY_ZOOM } },
+        { KE_KEY, 0x1c, { KEY_PROG2 } },
+        { KE_KEY, 0x1d, { KEY_PROG3 } },
+        { KE_KEY, NOTIFY_BRN_MIN, { KEY_BRIGHTNESSDOWN } },
+        { KE_KEY, NOTIFY_BRN_MAX, { KEY_BRIGHTNESSUP } },
+        { KE_KEY, 0x30, { KEY_SWITCHVIDEOMODE } },
+        { KE_KEY, 0x31, { KEY_SWITCHVIDEOMODE } },
+        { KE_KEY, 0x32, { KEY_SWITCHVIDEOMODE } },
+        { KE_KEY, 0x37, { KEY_F13 } }, /* Disable Touchpad */
+        { KE_KEY, 0x38, { KEY_F14 } },
+        { KE_END, 0 },
 };
 
-
 /*
  * This is the main structure, we can use it to store useful information
  */
@@ -159,6 +159,8 @@ struct eeepc_laptop {
         acpi_handle handle;             /* the handle of the acpi device */
         u32 cm_supported;               /* the control methods supported
                                            by this BIOS */
+        bool cpufv_disabled;
+        bool hotplug_disabled;
         u16 event_count[128];           /* count for each event */
 
         struct platform_device *platform_device;
@@ -378,6 +380,8 @@ static ssize_t store_cpufv(struct device *dev,
         struct eeepc_cpufv c;
         int rv, value;
 
+        if (eeepc->cpufv_disabled)
+                return -EPERM;
         if (get_cpufv(eeepc, &c))
                 return -ENODEV;
         rv = parse_arg(buf, count, &value);
@@ -389,6 +393,41 @@ static ssize_t store_cpufv(struct device *dev,
         return rv;
 }
 
+static ssize_t show_cpufv_disabled(struct device *dev,
+                          struct device_attribute *attr,
+                          char *buf)
+{
+        struct eeepc_laptop *eeepc = dev_get_drvdata(dev);
+
+        return sprintf(buf, "%d\n", eeepc->cpufv_disabled);
+}
+
+static ssize_t store_cpufv_disabled(struct device *dev,
+                           struct device_attribute *attr,
+                           const char *buf, size_t count)
+{
+        struct eeepc_laptop *eeepc = dev_get_drvdata(dev);
+        int rv, value;
+
+        rv = parse_arg(buf, count, &value);
+        if (rv < 0)
+                return rv;
+
+        switch (value) {
+        case 0:
+                if (eeepc->cpufv_disabled)
+                        pr_warning("cpufv enabled (not officially supported "
+                                "on this model)\n");
+                eeepc->cpufv_disabled = false;
+                return rv;
+        case 1:
+                return -EPERM;
+        default:
+                return -EINVAL;
+        }
+}
+
+
 static struct device_attribute dev_attr_cpufv = {
         .attr = {
                 .name = "cpufv",
@@ -404,12 +443,22 @@ static struct device_attribute dev_attr_available_cpufv = {
         .show   = show_available_cpufv
 };
 
+static struct device_attribute dev_attr_cpufv_disabled = {
+        .attr = {
+                .name = "cpufv_disabled",
+                .mode = 0644 },
+        .show   = show_cpufv_disabled,
+        .store  = store_cpufv_disabled
+};
+
+
 static struct attribute *platform_attributes[] = {
         &dev_attr_camera.attr,
         &dev_attr_cardr.attr,
         &dev_attr_disp.attr,
         &dev_attr_cpufv.attr,
         &dev_attr_available_cpufv.attr,
+        &dev_attr_cpufv_disabled.attr,
         NULL
 };
 
@@ -796,6 +845,9 @@ static int eeepc_rfkill_init(struct eeepc_laptop *eeepc)
         if (result && result != -ENODEV)
                 goto exit;
 
+        if (eeepc->hotplug_disabled)
+                return 0;
+
         result = eeepc_setup_pci_hotplug(eeepc);
         /*
          * If we get -EBUSY then something else is handling the PCI hotplug -
@@ -1090,120 +1142,42 @@ static void eeepc_backlight_exit(struct eeepc_laptop *eeepc)
 /*
  * Input device (i.e. hotkeys)
  */
-static struct key_entry *eeepc_get_entry_by_scancode(
-        struct eeepc_laptop *eeepc,
-        int code)
+static int eeepc_input_init(struct eeepc_laptop *eeepc)
 {
-        struct key_entry *key;
+        struct input_dev *input;
+        int error;
 
-        for (key = eeepc->keymap; key->type != KE_END; key++)
-                if (code == key->code)
-                        return key;
-
-        return NULL;
-}
-
-static void eeepc_input_notify(struct eeepc_laptop *eeepc, int event)
-{
-        static struct key_entry *key;
-
-        key = eeepc_get_entry_by_scancode(eeepc, event);
-        if (key) {
-                switch (key->type) {
-                case KE_KEY:
-                        input_report_key(eeepc->inputdev, key->keycode,
-                                                1);
-                        input_sync(eeepc->inputdev);
-                        input_report_key(eeepc->inputdev, key->keycode,
-                                                0);
-                        input_sync(eeepc->inputdev);
-                        break;
-                }
+        input = input_allocate_device();
+        if (!input) {
+                pr_info("Unable to allocate input device\n");
+                return -ENOMEM;
         }
-}
-
-static struct key_entry *eeepc_get_entry_by_keycode(
-        struct eeepc_laptop *eeepc, int code)
-{
-        struct key_entry *key;
-
-        for (key = eeepc->keymap; key->type != KE_END; key++)
-                if (code == key->keycode && key->type == KE_KEY)
-                        return key;
 
-        return NULL;
-}
+        input->name = "Asus EeePC extra buttons";
+        input->phys = EEEPC_LAPTOP_FILE "/input0";
+        input->id.bustype = BUS_HOST;
+        input->dev.parent = &eeepc->platform_device->dev;
 
-static int eeepc_getkeycode(struct input_dev *dev, int scancode, int *keycode)
-{
-        struct eeepc_laptop *eeepc = input_get_drvdata(dev);
-        struct key_entry *key = eeepc_get_entry_by_scancode(eeepc, scancode);
-
-        if (key && key->type == KE_KEY) {
-                *keycode = key->keycode;
-                return 0;
+        error = sparse_keymap_setup(input, eeepc_keymap, NULL);
+        if (error) {
+                pr_err("Unable to setup input device keymap\n");
+                goto err_free_dev;
         }
 
-        return -EINVAL;
-}
-
-static int eeepc_setkeycode(struct input_dev *dev, int scancode, int keycode)
-{
-        struct eeepc_laptop *eeepc = input_get_drvdata(dev);
-        struct key_entry *key;
-        int old_keycode;
-
-        if (keycode < 0 || keycode > KEY_MAX)
-                return -EINVAL;
-
-        key = eeepc_get_entry_by_scancode(eeepc, scancode);
-        if (key && key->type == KE_KEY) {
-                old_keycode = key->keycode;
-                key->keycode = keycode;
-                set_bit(keycode, dev->keybit);
-                if (!eeepc_get_entry_by_keycode(eeepc, old_keycode))
-                        clear_bit(old_keycode, dev->keybit);
-                return 0;
+        error = input_register_device(input);
+        if (error) {
+                pr_err("Unable to register input device\n");
+                goto err_free_keymap;
         }
 
-        return -EINVAL;
-}
-
-static int eeepc_input_init(struct eeepc_laptop *eeepc)
-{
-        const struct key_entry *key;
-        int result;
-
-        eeepc->inputdev = input_allocate_device();
-        if (!eeepc->inputdev) {
-                pr_info("Unable to allocate input device\n");
-                return -ENOMEM;
-        }
-        eeepc->inputdev->name = "Asus EeePC extra buttons";
-        eeepc->inputdev->dev.parent = &eeepc->platform_device->dev;
-        eeepc->inputdev->phys = EEEPC_LAPTOP_FILE "/input0";
-        eeepc->inputdev->id.bustype = BUS_HOST;
-        eeepc->inputdev->getkeycode = eeepc_getkeycode;
-        eeepc->inputdev->setkeycode = eeepc_setkeycode;
-        input_set_drvdata(eeepc->inputdev, eeepc);
-
-        eeepc->keymap = kmemdup(eeepc_keymap, sizeof(eeepc_keymap),
-                                GFP_KERNEL);
-        for (key = eeepc_keymap; key->type != KE_END; key++) {
-                switch (key->type) {
-                case KE_KEY:
-                        set_bit(EV_KEY, eeepc->inputdev->evbit);
-                        set_bit(key->keycode, eeepc->inputdev->keybit);
-                        break;
-                }
-        }
-        result = input_register_device(eeepc->inputdev);
-        if (result) {
-                pr_info("Unable to register input device\n");
-                input_free_device(eeepc->inputdev);
-                return result;
-        }
+        eeepc->inputdev = input;
         return 0;
+
+ err_free_keymap:
+        sparse_keymap_free(input);
+ err_free_dev:
+        input_free_device(input);
+        return error;
 }
 
 static void eeepc_input_exit(struct eeepc_laptop *eeepc)
@@ -1253,11 +1227,59 @@ static void eeepc_acpi_notify(struct acpi_device *device, u32 event)
                                 * event will be desired value (or else ignored)
                                 */
                         }
-                        eeepc_input_notify(eeepc, event);
+                        sparse_keymap_report_event(eeepc->inputdev, event,
+                                                   1, true);
                 }
         } else {
                 /* Everything else is a bona-fide keypress event */
-                eeepc_input_notify(eeepc, event);
+                sparse_keymap_report_event(eeepc->inputdev, event, 1, true);
+        }
+}
+
+static void eeepc_dmi_check(struct eeepc_laptop *eeepc)
+{
+        const char *model;
+
+        model = dmi_get_system_info(DMI_PRODUCT_NAME);
+        if (!model)
+                return;
+
+        /*
+         * Blacklist for setting cpufv (cpu speed).
+         *
+         * EeePC 4G ("701") implements CFVS, but it is not supported
+         * by the pre-installed OS, and the original option to change it
+         * in the BIOS setup screen was removed in later versions.
+         *
+         * Judging by the lack of "Super Hybrid Engine" on Asus product pages,
+         * this applies to all "701" models (4G/4G Surf/2G Surf).
+         *
+         * So Asus made a deliberate decision not to support it on this model.
+         * We have several reports that using it can cause the system to hang
+         *
+         * The hang has also been reported on a "702" (Model name "8G"?).
+         *
+         * We avoid dmi_check_system() / dmi_match(), because they use
+         * substring matching.  We don't want to affect the "701SD"
+         * and "701SDX" models, because they do support S.H.E.
+         */
+        if (strcmp(model, "701") == 0 || strcmp(model, "702") == 0) {
+                eeepc->cpufv_disabled = true;
+                pr_info("model %s does not officially support setting cpu "
+                        "speed\n", model);
+                pr_info("cpufv disabled to avoid instability\n");
+        }
+
+        /*
+         * Blacklist for wlan hotplug
+         *
+         * Eeepc 1005HA doesn't work like others models and don't need the
+         * hotplug code. In fact, current hotplug code seems to unplug another
+         * device...
+         */
+        if (strcmp(model, "1005HA") == 0 || strcmp(model, "1201N") == 0) {
+                eeepc->hotplug_disabled = true;
+                pr_info("wlan hotplug disabled\n");
         }
 }
 
@@ -1342,6 +1364,10 @@ static int __devinit eeepc_acpi_add(struct acpi_device *device)
         strcpy(acpi_device_class(device), EEEPC_ACPI_CLASS);
         device->driver_data = eeepc;
 
+        eeepc->hotplug_disabled = hotplug_disabled;
+
+        eeepc_dmi_check(eeepc);
+
         result = eeepc_acpi_init(eeepc, device);
         if (result)
                 goto fail_platform;
@@ -1452,10 +1478,12 @@ static int __init eeepc_laptop_init(void)
         result = acpi_bus_register_driver(&eeepc_acpi_driver);
         if (result < 0)
                 goto fail_acpi_driver;
+
         if (!eeepc_device_present) {
                 result = -ENODEV;
                 goto fail_no_device;
         }
+
         return 0;
 
 fail_no_device:
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index 8781d8fa7a5..ad4c414dbfb 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -338,8 +338,13 @@ static void hp_wmi_notify(u32 value, void *context)
         static struct key_entry *key;
         union acpi_object *obj;
         int eventcode;
+        acpi_status status;
 
-        wmi_get_event_data(value, &response);
+        status = wmi_get_event_data(value, &response);
+        if (status != AE_OK) {
+                printk(KERN_INFO "hp-wmi: bad event status 0x%x\n", status);
+                return;
+        }
 
         obj = (union acpi_object *)response.pointer;
 
@@ -388,8 +393,6 @@ static void hp_wmi_notify(u32 value, void *context)
         } else
                 printk(KERN_INFO "HP WMI: Unknown key pressed - %x\n",
                         eventcode);
-
-        kfree(obj);
 }
 
 static int __init hp_wmi_input_setup(void)
@@ -581,7 +584,7 @@ static int __init hp_wmi_init(void)
         if (wmi_has_guid(HPWMI_EVENT_GUID)) {
                 err = wmi_install_notify_handler(HPWMI_EVENT_GUID,
                                                  hp_wmi_notify, NULL);
-                if (!err)
+                if (ACPI_SUCCESS(err))
                         hp_wmi_input_setup();
         }
 
diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
index 7f77f908bb0..f5f70d4c691 100644
--- a/drivers/platform/x86/msi-wmi.c
+++ b/drivers/platform/x86/msi-wmi.c
@@ -149,8 +149,13 @@ static void msi_wmi_notify(u32 value, void *context)
         static struct key_entry *key;
         union acpi_object *obj;
         ktime_t cur;
+        acpi_status status;
 
-        wmi_get_event_data(value, &response);
+        status = wmi_get_event_data(value, &response);
+        if (status != AE_OK) {
+                printk(KERN_INFO DRV_PFX "bad event status 0x%x\n", status);
+                return;
+        }
 
         obj = (union acpi_object *)response.pointer;
 
@@ -236,7 +241,7 @@ static int __init msi_wmi_init(void)
         }
         err = wmi_install_notify_handler(MSIWMI_EVENT_GUID,
                         msi_wmi_notify, NULL);
-        if (err)
+        if (ACPI_FAILURE(err))
                 return -EINVAL;
 
         err = msi_wmi_input_setup();
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 5af53340da6..3f71a605a49 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -1201,9 +1201,12 @@ static void sony_nc_rfkill_setup(struct acpi_device *device)
         /* the buffer is filled with magic numbers describing the devices
          * available, 0xff terminates the enumeration
          */
-        while ((dev_code = *(device_enum->buffer.pointer + i)) != 0xff &&
-                        i < device_enum->buffer.length) {
-                i++;
+        for (i = 0; i < device_enum->buffer.length; i++) {
+
+                dev_code = *(device_enum->buffer.pointer + i);
+                if (dev_code == 0xff)
+                        break;
+
                 dprintk("Radio devices, looking at 0x%.2x\n", dev_code);
 
                 if (dev_code == 0 && !sony_rfkill_devices[SONY_WIFI])
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 448c8aeb166..e67e4feb35c 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6384,11 +6384,13 @@ static struct ibm_struct brightness_driver_data = {
  * and we leave them unchanged.
  */
 
+#ifdef CONFIG_THINKPAD_ACPI_ALSA_SUPPORT
+
 #define TPACPI_ALSA_DRVNAME  "ThinkPad EC"
 #define TPACPI_ALSA_SHRTNAME "ThinkPad Console Audio Control"
 #define TPACPI_ALSA_MIXERNAME TPACPI_ALSA_SHRTNAME
 
-static int alsa_index = SNDRV_DEFAULT_IDX1;
+static int alsa_index = ~((1 << (SNDRV_CARDS - 3)) - 1); /* last three slots */
 static char *alsa_id = "ThinkPadEC";
 static int alsa_enable = SNDRV_DEFAULT_ENABLE1;
 
@@ -6705,10 +6707,11 @@ static int __init volume_create_alsa_mixer(void)
 
         rc = snd_card_create(alsa_index, alsa_id, THIS_MODULE,
                             sizeof(struct tpacpi_alsa_data), &card);
-        if (rc < 0)
-                return rc;
-        if (!card)
-                return -ENOMEM;
+        if (rc < 0 || !card) {
+                printk(TPACPI_ERR
+                        "Failed to create ALSA card structures: %d\n", rc);
+                return 1;
+        }
 
         BUG_ON(!card->private_data);
         data = card->private_data;
@@ -6741,8 +6744,9 @@ static int __init volume_create_alsa_mixer(void)
                 rc = snd_ctl_add(card, ctl_vol);
                 if (rc < 0) {
                         printk(TPACPI_ERR
-                                "Failed to create ALSA volume control\n");
-                        goto err_out;
+                                "Failed to create ALSA volume control: %d\n",
+                                rc);
+                        goto err_exit;
                 }
                 data->ctl_vol_id = &ctl_vol->id;
         }
@@ -6750,22 +6754,25 @@ static int __init volume_create_alsa_mixer(void)
         ctl_mute = snd_ctl_new1(&volume_alsa_control_mute, NULL);
         rc = snd_ctl_add(card, ctl_mute);
         if (rc < 0) {
-                printk(TPACPI_ERR "Failed to create ALSA mute control\n");
-                goto err_out;
+                printk(TPACPI_ERR "Failed to create ALSA mute control: %d\n",
+                        rc);
+                goto err_exit;
         }
         data->ctl_mute_id = &ctl_mute->id;
 
         snd_card_set_dev(card, &tpacpi_pdev->dev);
         rc = snd_card_register(card);
-
-err_out:
         if (rc < 0) {
-                snd_card_free(card);
-                card = NULL;
+                printk(TPACPI_ERR "Failed to register ALSA card: %d\n", rc);
+                goto err_exit;
         }
 
         alsa_card = card;
-        return rc;
+        return 0;
+
+err_exit:
+        snd_card_free(card);
+        return 1;
 }
 
 #define TPACPI_VOL_Q_MUTEONLY   0x0001  /* Mute-only control available */
@@ -7016,6 +7023,28 @@ static struct ibm_struct volume_driver_data = {
         .shutdown = volume_shutdown,
 };
 
+#else /* !CONFIG_THINKPAD_ACPI_ALSA_SUPPORT */
+
+#define alsa_card NULL
+
+static void inline volume_alsa_notify_change(void)
+{
+}
+
+static int __init volume_init(struct ibm_init_struct *iibm)
+{
+        printk(TPACPI_INFO
+                "volume: disabled as there is no ALSA support in this kernel\n");
+
+        return 1;
+}
+
+static struct ibm_struct volume_driver_data = {
+        .name = "volume",
+};
+
+#endif /* CONFIG_THINKPAD_ACPI_ALSA_SUPPORT */
+
 /*************************************************************************
  * Fan subdriver
  */
@@ -8738,6 +8767,7 @@ MODULE_PARM_DESC(hotkey_report_mode,
                  "used for backwards compatibility with userspace, "
                  "see documentation");
 
+#ifdef CONFIG_THINKPAD_ACPI_ALSA_SUPPORT
 module_param_named(volume_mode, volume_mode, uint, 0444);
 MODULE_PARM_DESC(volume_mode,
                  "Selects volume control strategy: "
@@ -8760,6 +8790,7 @@ module_param_named(id, alsa_id, charp, 0444);
 MODULE_PARM_DESC(id, "ALSA id for the ACPI EC Mixer");
 module_param_named(enable, alsa_enable, bool, 0444);
 MODULE_PARM_DESC(enable, "Enable the ALSA interface for the ACPI EC Mixer");
+#endif /* CONFIG_THINKPAD_ACPI_ALSA_SUPPORT */
 
 #define TPACPI_PARAM(feature) \
         module_param_call(feature, set_ibm_param, NULL, NULL, 0); \
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 9f93d6c0f51..b104302fea0 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -492,8 +492,7 @@ wmi_notify_handler handler, void *data)
         if (!guid || !handler)
                 return AE_BAD_PARAMETER;
 
-        find_guid(guid, &block);
-        if (!block)
+        if (!find_guid(guid, &block))
                 return AE_NOT_EXIST;
 
         if (block->handler)
@@ -521,8 +520,7 @@ acpi_status wmi_remove_notify_handler(const char *guid)
         if (!guid)
                 return AE_BAD_PARAMETER;
 
-        find_guid(guid, &block);
-        if (!block)
+        if (!find_guid(guid, &block))
                 return AE_NOT_EXIST;
 
         if (!block->handler)
@@ -716,6 +714,22 @@ static int wmi_class_init(void)
         return ret;
 }
 
+static bool guid_already_parsed(const char *guid_string)
+{
+        struct guid_block *gblock;
+        struct wmi_block *wblock;
+        struct list_head *p;
+
+        list_for_each(p, &wmi_blocks.list) {
+                wblock = list_entry(p, struct wmi_block, list);
+                gblock = &wblock->gblock;
+
+                if (strncmp(gblock->guid, guid_string, 16) == 0)
+                        return true;
+        }
+        return false;
+}
+
 /*
  * Parse the _WDG method for the GUID data blocks
  */
@@ -725,6 +739,7 @@ static __init acpi_status parse_wdg(acpi_handle handle)
         union acpi_object *obj;
         struct guid_block *gblock;
         struct wmi_block *wblock;
+        char guid_string[37];
         acpi_status status;
         u32 i, total;
 
@@ -747,6 +762,19 @@ static __init acpi_status parse_wdg(acpi_handle handle)
         memcpy(gblock, obj->buffer.pointer, obj->buffer.length);
 
         for (i = 0; i < total; i++) {
+                /*
+                  Some WMI devices, like those for nVidia hooks, have a
+                  duplicate GUID. It's not clear what we should do in this
+                  case yet, so for now, we'll just ignore the duplicate.
+                  Anyone who wants to add support for that device can come
+                  up with a better workaround for the mess then.
+                */
+                if (guid_already_parsed(gblock[i].guid) == true) {
+                        wmi_gtoa(gblock[i].guid, guid_string);
+                        printk(KERN_INFO PREFIX "Skipping duplicate GUID %s\n",
+                                guid_string);
+                        continue;
+                }
                 wblock = kzalloc(sizeof(struct wmi_block), GFP_KERNEL);
                 if (!wblock)
                         return AE_NO_MEMORY;