diff options
author | Julia Lawall <julia@diku.dk> | 2008-01-07 07:33:45 -0500 |
---|---|---|
committer | Jaroslav Kysela <perex@perex.cz> | 2008-01-31 11:29:45 -0500 |
commit | f11b799282201fbd8c88b51815176a902b1f15b8 (patch) | |
tree | 920484c5838086249f4d5f9a69632823987641cf /sound/soc/s3c24xx | |
parent | 1bc9eed379399484d3f5d5a0834674983969bc1e (diff) |
[ALSA] sound: Use time_before, time_before_eq, etc.
The functions time_before, time_before_eq, time_after, and time_after_eq
are more robust for comparing jiffies against other values.
A simplified version of the semantic patch making this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@ change_compare_np @
expression E;
@@
(
- jiffies <= E
+ time_before_eq(jiffies,E)
|
- jiffies >= E
+ time_after_eq(jiffies,E)
|
- jiffies < E
+ time_before(jiffies,E)
|
- jiffies > E
+ time_after(jiffies,E)
)
@ include depends on change_compare_np @
@@
#include <linux/jiffies.h>
@ no_include depends on !include && change_compare_np @
@@
#include <linux/...>
+ #include <linux/jiffies.h>
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Diffstat (limited to 'sound/soc/s3c24xx')
-rw-r--r-- | sound/soc/s3c24xx/s3c24xx-i2s.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/soc/s3c24xx/s3c24xx-i2s.c b/sound/soc/s3c24xx/s3c24xx-i2s.c index fe30e0d82d3..9d8af3a46da 100644 --- a/sound/soc/s3c24xx/s3c24xx-i2s.c +++ b/sound/soc/s3c24xx/s3c24xx-i2s.c | |||
@@ -24,6 +24,7 @@ | |||
24 | #include <linux/device.h> | 24 | #include <linux/device.h> |
25 | #include <linux/delay.h> | 25 | #include <linux/delay.h> |
26 | #include <linux/clk.h> | 26 | #include <linux/clk.h> |
27 | #include <linux/jiffies.h> | ||
27 | #include <sound/driver.h> | 28 | #include <sound/driver.h> |
28 | #include <sound/core.h> | 29 | #include <sound/core.h> |
29 | #include <sound/pcm.h> | 30 | #include <sound/pcm.h> |
@@ -185,7 +186,7 @@ static int s3c24xx_snd_lrsync(void) | |||
185 | if (iiscon & S3C2410_IISCON_LRINDEX) | 186 | if (iiscon & S3C2410_IISCON_LRINDEX) |
186 | break; | 187 | break; |
187 | 188 | ||
188 | if (timeout < jiffies) | 189 | if (time_after(jiffies, timeout)) |
189 | return -ETIMEDOUT; | 190 | return -ETIMEDOUT; |
190 | } | 191 | } |
191 | 192 | ||