diff options
author | Nicolas Palix <npalix@diku.dk> | 2010-08-24 11:39:07 -0400 |
---|---|---|
committer | Michal Marek <mmarek@suse.cz> | 2010-08-31 05:37:54 -0400 |
commit | 034174598bc8ffd9586432852502e368a43ef0f1 (patch) | |
tree | f49d60d39b1a7c7b67d27d09c54214f5e76172c0 /scripts/coccinelle | |
parent | 0426a97c4b672166cbcfdc7b18466d4f207f7a36 (diff) |
Coccinelle: Add api/memdup_user
Use kmemdup_user rather than duplicating its implementation
This is a little bit restricted to reduce false positives
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'scripts/coccinelle')
-rw-r--r-- | scripts/coccinelle/api/memdup_user.cocci | 35 |
1 files changed, 35 insertions, 0 deletions
diff --git a/scripts/coccinelle/api/memdup_user.cocci b/scripts/coccinelle/api/memdup_user.cocci new file mode 100644 index 00000000000..72ce012e878 --- /dev/null +++ b/scripts/coccinelle/api/memdup_user.cocci | |||
@@ -0,0 +1,35 @@ | |||
1 | /// Use kmemdup_user rather than duplicating its implementation | ||
2 | /// This is a little bit restricted to reduce false positives | ||
3 | /// | ||
4 | // Confidence: High | ||
5 | // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. | ||
6 | // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. | ||
7 | // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. | ||
8 | // URL: http://coccinelle.lip6.fr/ | ||
9 | // Comments: | ||
10 | // Options: -no_includes -include_headers | ||
11 | |||
12 | virtual patch | ||
13 | |||
14 | @@ | ||
15 | expression from,to,size,flag; | ||
16 | position p; | ||
17 | identifier l1,l2; | ||
18 | @@ | ||
19 | |||
20 | - to = \(kmalloc@p\|kzalloc@p\)(size,flag); | ||
21 | + to = memdup_user(from,size); | ||
22 | if ( | ||
23 | - to==NULL | ||
24 | + IS_ERR(to) | ||
25 | || ...) { | ||
26 | <+... when != goto l1; | ||
27 | - -ENOMEM | ||
28 | + PTR_ERR(to) | ||
29 | ...+> | ||
30 | } | ||
31 | - if (copy_from_user(to, from, size) != 0) { | ||
32 | - <+... when != goto l2; | ||
33 | - -EFAULT | ||
34 | - ...+> | ||
35 | - } | ||