Merge branch 'devel'

1 files changed, 30 insertions, 20 deletions

diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 7b96ff38002..8945307556e 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -544,7 +544,7 @@ EXPORT_SYMBOL_GPL(rpc_run_task);
  * @msg: RPC call parameters
  * @flags: RPC call flags
  */
-int rpc_call_sync(struct rpc_clnt *clnt, struct rpc_message *msg, int flags)
+int rpc_call_sync(struct rpc_clnt *clnt, const struct rpc_message *msg, int flags)
 {
         struct rpc_task *task;
         struct rpc_task_setup task_setup_data = {
@@ -575,7 +575,7 @@ EXPORT_SYMBOL_GPL(rpc_call_sync);
  * @data: user call data
  */
 int
-rpc_call_async(struct rpc_clnt *clnt, struct rpc_message *msg, int flags,
+rpc_call_async(struct rpc_clnt *clnt, const struct rpc_message *msg, int flags,
                const struct rpc_call_ops *tk_ops, void *data)
 {
         struct rpc_task *task;
@@ -1062,7 +1062,7 @@ call_transmit(struct rpc_task *task)
         if (task->tk_msg.rpc_proc->p_decode != NULL)
                 return;
         task->tk_action = rpc_exit_task;
-        rpc_wake_up_task(task);
+        rpc_wake_up_queued_task(&task->tk_xprt->pending, task);
 }
 
 /*
@@ -1116,7 +1116,8 @@ call_status(struct rpc_task *task)
         case -ETIMEDOUT:
                 task->tk_action = call_timeout;
                 if (task->tk_client->cl_discrtry)
-                        xprt_force_disconnect(task->tk_xprt);
+                        xprt_conditional_disconnect(task->tk_xprt,
+                                        req->rq_connect_cookie);
                 break;
         case -ECONNREFUSED:
         case -ENOTCONN:
@@ -1168,6 +1169,11 @@ call_timeout(struct rpc_task *task)
                         clnt->cl_protname, clnt->cl_server);
         }
         rpc_force_rebind(clnt);
+        /*
+         * Did our request time out due to an RPCSEC_GSS out-of-sequence
+         * event? RFC2203 requires the server to drop all such requests.
+         */
+        rpcauth_invalcred(task);
 
 retry:
         clnt->cl_stats->rpcretrans++;
@@ -1195,18 +1201,6 @@ call_decode(struct rpc_task *task)
                 task->tk_flags &= ~RPC_CALL_MAJORSEEN;
         }
 
-        if (task->tk_status < 12) {
-                if (!RPC_IS_SOFT(task)) {
-                        task->tk_action = call_bind;
-                        clnt->cl_stats->rpcretrans++;
-                        goto out_retry;
-                }
-                dprintk("RPC:       %s: too small RPC reply size (%d bytes)\n",
-                                clnt->cl_protname, task->tk_status);
-                task->tk_action = call_timeout;
-                goto out_retry;
-        }
-
         /*
          * Ensure that we see all writes made by xprt_complete_rqst()
          * before it changed req->rq_received.
@@ -1218,6 +1212,18 @@ call_decode(struct rpc_task *task)
         WARN_ON(memcmp(&req->rq_rcv_buf, &req->rq_private_buf,
                                 sizeof(req->rq_rcv_buf)) != 0);
 
+        if (req->rq_rcv_buf.len < 12) {
+                if (!RPC_IS_SOFT(task)) {
+                        task->tk_action = call_bind;
+                        clnt->cl_stats->rpcretrans++;
+                        goto out_retry;
+                }
+                dprintk("RPC:       %s: too small RPC reply size (%d bytes)\n",
+                                clnt->cl_protname, task->tk_status);
+                task->tk_action = call_timeout;
+                goto out_retry;
+        }
+
         /* Verify the RPC header */
         p = call_verify(task);
         if (IS_ERR(p)) {
@@ -1236,10 +1242,14 @@ call_decode(struct rpc_task *task)
                         task->tk_status);
         return;
 out_retry:
-        req->rq_received = req->rq_private_buf.len = 0;
         task->tk_status = 0;
-        if (task->tk_client->cl_discrtry)
-                xprt_force_disconnect(task->tk_xprt);
+        /* Note: call_verify() may have freed the RPC slot */
+        if (task->tk_rqstp == req) {
+                req->rq_received = req->rq_rcv_buf.len = 0;
+                if (task->tk_client->cl_discrtry)
+                        xprt_conditional_disconnect(task->tk_xprt,
+                                        req->rq_connect_cookie);
+        }
 }
 
 /*
@@ -1531,7 +1541,7 @@ void rpc_show_tasks(void)
                                 proc = -1;
 
                         if (RPC_IS_QUEUED(t))
-                                rpc_waitq = rpc_qname(t->u.tk_wait.rpc_waitq);
+                                rpc_waitq = rpc_qname(t->tk_waitqueue);
 
                         printk("%5u %04d %04x %6d %8p %6d %8p %8ld %8s %8p %8p\n",
                                 t->tk_pid, proc,