diff options
author | Herbert Xu <herbert@gondor.apana.org.au> | 2007-12-12 21:47:48 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 17:57:41 -0500 |
commit | 7233b9f33e72ca477034ff5cf901c89efba3a5bc (patch) | |
tree | 91f3ca124a86cd0be9ac068a98e895923e4c03f8 /net/ipv4 | |
parent | 2ba582b782071c038b312ea330d3090a39f3c66a (diff) |
[IPSEC]: Fix reversed ICMP6 policy check
The policy check I added for ICMP on IPv6 is reversed. This
patch fixes that.
It also adds an skb->sp check so that unprotected packets that
fail the policy check do not crash the machine.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
-rw-r--r-- | net/ipv4/icmp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 3c41a6f7e6e..c41f3cc4fba 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c | |||
@@ -977,7 +977,7 @@ int icmp_rcv(struct sk_buff *skb) | |||
977 | struct icmphdr *icmph; | 977 | struct icmphdr *icmph; |
978 | struct rtable *rt = (struct rtable *)skb->dst; | 978 | struct rtable *rt = (struct rtable *)skb->dst; |
979 | 979 | ||
980 | if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb) && | 980 | if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb) && skb->sp && |
981 | skb->sp->xvec[skb->sp->len - 1]->props.flags & XFRM_STATE_ICMP) { | 981 | skb->sp->xvec[skb->sp->len - 1]->props.flags & XFRM_STATE_ICMP) { |
982 | int nh; | 982 | int nh; |
983 | 983 | ||