[SK_BUFF]: unions of just one member don't get anything done, kill them

Renaming skb->h to skb->transport_header, skb->nh to skb->network_header and
skb->mac to skb->mac_header, to match the names of the associated helpers
(skb[_[re]set]_{transport,network,mac}_header).

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

3 files changed, 22 insertions, 21 deletions

diff --git a/net/core/dev.c b/net/core/dev.c
index 30fcc7f9d4e..6562e5736e2 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1077,7 +1077,7 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev)
                                 skb_reset_network_header(skb2);
                         }
 
-                        skb2->h.raw = skb2->nh.raw;
+                        skb2->transport_header = skb2->network_header;
                         skb2->pkt_type = PACKET_OUTGOING;
                         ptype->func(skb2, skb->dev, ptype, skb->dev);
                 }
@@ -1207,7 +1207,7 @@ struct sk_buff *skb_gso_segment(struct sk_buff *skb, int features)
         BUG_ON(skb_shinfo(skb)->frag_list);
 
         skb_reset_mac_header(skb);
-        skb->mac_len = skb->nh.raw - skb->mac.raw;
+        skb->mac_len = skb->network_header - skb->mac_header;
         __skb_pull(skb, skb->mac_len);
 
         if (unlikely(skb->ip_summed != CHECKSUM_PARTIAL)) {
@@ -1774,7 +1774,7 @@ int netif_receive_skb(struct sk_buff *skb)
 
         skb_reset_network_header(skb);
         skb_reset_transport_header(skb);
-        skb->mac_len = skb->nh.raw - skb->mac.raw;
+        skb->mac_len = skb->network_header - skb->mac_header;
 
         pt_prev = NULL;
 
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index ae8cf9a285f..9da8357addc 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -2358,7 +2358,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
         }
 
         skb_set_network_header(skb, skb->tail - skb->data);
-        skb->h.raw = skb->nh.raw + sizeof(struct iphdr);
+        skb->transport_header = skb->network_header + sizeof(struct iphdr);
         skb_put(skb, sizeof(struct iphdr) + sizeof(struct udphdr));
 
         iph = ip_hdr(skb);
@@ -2391,9 +2391,9 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
         iph->check = 0;
         iph->check = ip_fast_csum((void *)iph, iph->ihl);
         skb->protocol = protocol;
-        skb->mac.raw = (skb->nh.raw - ETH_HLEN -
-                        pkt_dev->nr_labels * sizeof(u32) -
-                        VLAN_TAG_SIZE(pkt_dev) - SVLAN_TAG_SIZE(pkt_dev));
+        skb->mac_header = (skb->network_header - ETH_HLEN -
+                           pkt_dev->nr_labels * sizeof(u32) -
+                           VLAN_TAG_SIZE(pkt_dev) - SVLAN_TAG_SIZE(pkt_dev));
         skb->dev = odev;
         skb->pkt_type = PACKET_HOST;
 
@@ -2697,7 +2697,7 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,
         }
 
         skb_set_network_header(skb, skb->tail - skb->data);
-        skb->h.raw = skb->nh.raw + sizeof(struct ipv6hdr);
+        skb->transport_header = skb->network_header + sizeof(struct ipv6hdr);
         skb_put(skb, sizeof(struct ipv6hdr) + sizeof(struct udphdr));
 
         iph = ipv6_hdr(skb);
@@ -2738,9 +2738,9 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,
         ipv6_addr_copy(&iph->daddr, &pkt_dev->cur_in6_daddr);
         ipv6_addr_copy(&iph->saddr, &pkt_dev->cur_in6_saddr);
 
-        skb->mac.raw = (skb->nh.raw - ETH_HLEN -
-                        pkt_dev->nr_labels * sizeof(u32) -
-                        VLAN_TAG_SIZE(pkt_dev) - SVLAN_TAG_SIZE(pkt_dev));
+        skb->mac_header = (skb->network_header - ETH_HLEN -
+                           pkt_dev->nr_labels * sizeof(u32) -
+                           VLAN_TAG_SIZE(pkt_dev) - SVLAN_TAG_SIZE(pkt_dev));
         skb->protocol = protocol;
         skb->dev = odev;
         skb->pkt_type = PACKET_HOST;
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index f38af6c01b1..1e71764be4a 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -396,9 +396,9 @@ struct sk_buff *skb_clone(struct sk_buff *skb, gfp_t gfp_mask)
         n->sk = NULL;
         C(tstamp);
         C(dev);
-        C(h);
-        C(nh);
-        C(mac);
+        C(transport_header);
+        C(network_header);
+        C(mac_header);
         C(dst);
         dst_clone(skb->dst);
         C(sp);
@@ -461,9 +461,9 @@ static void copy_skb_header(struct sk_buff *new, const struct sk_buff *old)
 #ifdef CONFIG_INET
         new->sp         = secpath_get(old->sp);
 #endif
-        new->h.raw      = old->h.raw + offset;
-        new->nh.raw     = old->nh.raw + offset;
-        new->mac.raw    = old->mac.raw + offset;
+        new->transport_header = old->transport_header + offset;
+        new->network_header   = old->network_header + offset;
+        new->mac_header       = old->mac_header + offset;
         memcpy(new->cb, old->cb, sizeof(old->cb));
         new->local_df   = old->local_df;
         new->fclone     = SKB_FCLONE_UNAVAILABLE;
@@ -639,9 +639,9 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,
         skb->end      = data + size;
         skb->data    += off;
         skb->tail    += off;
-        skb->mac.raw += off;
-        skb->h.raw   += off;
-        skb->nh.raw  += off;
+        skb->transport_header += off;
+        skb->network_header   += off;
+        skb->mac_header       += off;
         skb->cloned   = 0;
         skb->nohdr    = 0;
         atomic_set(&skb_shinfo(skb)->dataref, 1);
@@ -1906,7 +1906,8 @@ struct sk_buff *skb_segment(struct sk_buff *skb, int features)
                 skb_reserve(nskb, headroom);
                 skb_reset_mac_header(nskb);
                 skb_set_network_header(nskb, skb->mac_len);
-                nskb->h.raw = nskb->nh.raw + skb_network_header_len(skb);
+                nskb->transport_header = (nskb->network_header +
+                                          skb_network_header_len(skb));
                 memcpy(skb_put(nskb, doffset), skb->data, doffset);
 
                 if (!sg) {