[ETH]: Combine format_addr() with print_mac().

print_mac() used many most net drivers and format_addr() used by
net-sysfs.c are very similar and they can be intergrated.

format_addr() is also identically redefined in the qla4xxx iscsi
driver.

Export a new function sysfs_format_mac() to be used by net-sysfs,
qla4xxx and others in the future.  Both print_mac() and
sysfs_format_mac() call _format_mac_addr() to do the formatting.

Changed print_mac() to use unsigned char * to be consistent with
net_device struct's dev_addr.  Added buffer length overrun checking
as suggested by Joe Perches.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 2 insertions, 13 deletions

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index e41f4b9d2e7..7635d3f7272 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -95,17 +95,6 @@ NETDEVICE_SHOW(type, fmt_dec);
 NETDEVICE_SHOW(link_mode, fmt_dec);
 
 /* use same locking rules as GIFHWADDR ioctl's */
-static ssize_t format_addr(char *buf, const unsigned char *addr, int len)
-{
-        int i;
-        char *cp = buf;
-
-        for (i = 0; i < len; i++)
-                cp += sprintf(cp, "%02x%c", addr[i],
-                              i == (len - 1) ? '\n' : ':');
-        return cp - buf;
-}
-
 static ssize_t show_address(struct device *dev, struct device_attribute *attr,
                             char *buf)
 {
@@ -114,7 +103,7 @@ static ssize_t show_address(struct device *dev, struct device_attribute *attr,
 
         read_lock(&dev_base_lock);
         if (dev_isalive(net))
-            ret = format_addr(buf, net->dev_addr, net->addr_len);
+                ret = sysfs_format_mac(buf, net->dev_addr, net->addr_len);
         read_unlock(&dev_base_lock);
         return ret;
 }
@@ -124,7 +113,7 @@ static ssize_t show_broadcast(struct device *dev,
 {
         struct net_device *net = to_net_dev(dev);
         if (dev_isalive(net))
-                return format_addr(buf, net->broadcast, net->addr_len);
+                return sysfs_format_mac(buf, net->broadcast, net->addr_len);
         return -EINVAL;
 }