diff options
author | Paul Mundt <lethal@linux-sh.org> | 2007-07-20 03:31:44 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-20 11:44:19 -0400 |
commit | e228929bc257b963523ed75aa60d2ad77ece2189 (patch) | |
tree | d72cf8e6d8a126792565549527efc2c9a6fcdcbe /mm | |
parent | 8d1b87530e7df5c9541a69910ef7f786f034eca0 (diff) |
mm: fix memory hotplug oops from ZONE_MOVABLE changes.
zone_movable_pfn is presently marked as __initdata and referenced from
adjust_zone_range_for_zone_movable(), which in turn is referenced by
zone_spanned_pages_in_node(). Both of these are __meminit annotated. When
memory hotplug is enabled, this will oops on a hot-add, due to
zone_movable_pfn having been freed.
__meminitdata annotation gives the desired behaviour.
This will only impact platforms that enable both memory hotplug
and ARCH_POPULATES_NODE_MAP.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Mel Gorman <mel@csn.ul.ie>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/page_alloc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 43cb3b3e167..40954fb8159 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c | |||
@@ -138,7 +138,7 @@ static unsigned long __meminitdata dma_reserve; | |||
138 | #endif /* CONFIG_MEMORY_HOTPLUG_RESERVE */ | 138 | #endif /* CONFIG_MEMORY_HOTPLUG_RESERVE */ |
139 | unsigned long __initdata required_kernelcore; | 139 | unsigned long __initdata required_kernelcore; |
140 | unsigned long __initdata required_movablecore; | 140 | unsigned long __initdata required_movablecore; |
141 | unsigned long __initdata zone_movable_pfn[MAX_NUMNODES]; | 141 | unsigned long __meminitdata zone_movable_pfn[MAX_NUMNODES]; |
142 | 142 | ||
143 | /* movable_zone is the "real" zone pages in ZONE_MOVABLE are taken from */ | 143 | /* movable_zone is the "real" zone pages in ZONE_MOVABLE are taken from */ |
144 | int movable_zone; | 144 | int movable_zone; |