diff options
author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-10-18 23:27:06 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-20 11:52:32 -0400 |
commit | 2a4b3ded5c76fbe373d6415b1b3ad4841f15c9bd (patch) | |
tree | 32569113d280e8b69c81359246a51173b187ed74 /mm/hugetlb.c | |
parent | db64fe02258f1507e13fe5212a989922323685ce (diff) |
mm: hugetlb.c make functions static, use NULL rather than 0
mm/hugetlb.c:265:17: warning: symbol 'resv_map_alloc' was not declared. Should it be static?
mm/hugetlb.c:277:6: warning: symbol 'resv_map_release' was not declared. Should it be static?
mm/hugetlb.c:292:9: warning: Using plain integer as NULL pointer
mm/hugetlb.c:1750:5: warning: symbol 'unmap_ref_private' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Acked-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/hugetlb.c')
-rw-r--r-- | mm/hugetlb.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 2fc7fddd9b1..ab79cd4dd23 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c | |||
@@ -262,7 +262,7 @@ struct resv_map { | |||
262 | struct list_head regions; | 262 | struct list_head regions; |
263 | }; | 263 | }; |
264 | 264 | ||
265 | struct resv_map *resv_map_alloc(void) | 265 | static struct resv_map *resv_map_alloc(void) |
266 | { | 266 | { |
267 | struct resv_map *resv_map = kmalloc(sizeof(*resv_map), GFP_KERNEL); | 267 | struct resv_map *resv_map = kmalloc(sizeof(*resv_map), GFP_KERNEL); |
268 | if (!resv_map) | 268 | if (!resv_map) |
@@ -274,7 +274,7 @@ struct resv_map *resv_map_alloc(void) | |||
274 | return resv_map; | 274 | return resv_map; |
275 | } | 275 | } |
276 | 276 | ||
277 | void resv_map_release(struct kref *ref) | 277 | static void resv_map_release(struct kref *ref) |
278 | { | 278 | { |
279 | struct resv_map *resv_map = container_of(ref, struct resv_map, refs); | 279 | struct resv_map *resv_map = container_of(ref, struct resv_map, refs); |
280 | 280 | ||
@@ -289,7 +289,7 @@ static struct resv_map *vma_resv_map(struct vm_area_struct *vma) | |||
289 | if (!(vma->vm_flags & VM_SHARED)) | 289 | if (!(vma->vm_flags & VM_SHARED)) |
290 | return (struct resv_map *)(get_vma_private_data(vma) & | 290 | return (struct resv_map *)(get_vma_private_data(vma) & |
291 | ~HPAGE_RESV_MASK); | 291 | ~HPAGE_RESV_MASK); |
292 | return 0; | 292 | return NULL; |
293 | } | 293 | } |
294 | 294 | ||
295 | static void set_vma_resv_map(struct vm_area_struct *vma, struct resv_map *map) | 295 | static void set_vma_resv_map(struct vm_area_struct *vma, struct resv_map *map) |
@@ -1747,10 +1747,8 @@ void unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start, | |||
1747 | * from other VMAs and let the children be SIGKILLed if they are faulting the | 1747 | * from other VMAs and let the children be SIGKILLed if they are faulting the |
1748 | * same region. | 1748 | * same region. |
1749 | */ | 1749 | */ |
1750 | int unmap_ref_private(struct mm_struct *mm, | 1750 | static int unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma, |
1751 | struct vm_area_struct *vma, | 1751 | struct page *page, unsigned long address) |
1752 | struct page *page, | ||
1753 | unsigned long address) | ||
1754 | { | 1752 | { |
1755 | struct vm_area_struct *iter_vma; | 1753 | struct vm_area_struct *iter_vma; |
1756 | struct address_space *mapping; | 1754 | struct address_space *mapping; |