aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/kmod.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@tv-sign.ru>2007-05-09 05:34:36 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-05-09 15:30:53 -0400
commit90cce03d9bfcb28600a56efef6b0a5a4fbf6c2b1 (patch)
treef0b1909311fe5662eeac7923bd7830a9811ac2aa /kernel/kmod.c
parentb8a124da9261873e3e3541898d5c46d273afee34 (diff)
wait_for_helper: remove unneeded do_sigaction()
allow_signal(SIGCHLD) does all necessary job, no need to call do_sigaction() prior to. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/kmod.c')
-rw-r--r--kernel/kmod.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/kernel/kmod.c b/kernel/kmod.c
index 6cea9db25c3..4d32eb07717 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -185,14 +185,9 @@ static int wait_for_helper(void *data)
185{ 185{
186 struct subprocess_info *sub_info = data; 186 struct subprocess_info *sub_info = data;
187 pid_t pid; 187 pid_t pid;
188 struct k_sigaction sa;
189 188
190 /* Install a handler: if SIGCLD isn't handled sys_wait4 won't 189 /* Install a handler: if SIGCLD isn't handled sys_wait4 won't
191 * populate the status, but will return -ECHILD. */ 190 * populate the status, but will return -ECHILD. */
192 sa.sa.sa_handler = SIG_IGN;
193 sa.sa.sa_flags = 0;
194 siginitset(&sa.sa.sa_mask, sigmask(SIGCHLD));
195 do_sigaction(SIGCHLD, &sa, NULL);
196 allow_signal(SIGCHLD); 191 allow_signal(SIGCHLD);
197 192
198 pid = kernel_thread(____call_usermodehelper, sub_info, SIGCHLD); 193 pid = kernel_thread(____call_usermodehelper, sub_info, SIGCHLD);