diff options
author | Oleg Nesterov <oleg@redhat.com> | 2010-05-26 17:43:05 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-27 12:12:45 -0400 |
commit | 04b1c384fbc4e0209e5c1affb67050886376d44b (patch) | |
tree | 19bc8690113dd6ded88d465a0777cb8bf7e33262 /kernel/kmod.c | |
parent | d47419cd967a4f032a194148a7b08afad32faded (diff) |
call_usermodehelper: UMH_WAIT_EXEC ignores kernel_thread() failure
UMH_WAIT_EXEC should report the error if kernel_thread() fails, like
UMH_WAIT_PROC does.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/kmod.c')
-rw-r--r-- | kernel/kmod.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/kmod.c b/kernel/kmod.c index ad9f2edebd6..6e9b19667a8 100644 --- a/kernel/kmod.c +++ b/kernel/kmod.c | |||
@@ -235,10 +235,10 @@ static void __call_usermodehelper(struct work_struct *work) | |||
235 | case UMH_WAIT_PROC: | 235 | case UMH_WAIT_PROC: |
236 | if (pid > 0) | 236 | if (pid > 0) |
237 | break; | 237 | break; |
238 | sub_info->retval = pid; | ||
239 | /* FALLTHROUGH */ | 238 | /* FALLTHROUGH */ |
240 | |||
241 | case UMH_WAIT_EXEC: | 239 | case UMH_WAIT_EXEC: |
240 | if (pid < 0) | ||
241 | sub_info->retval = pid; | ||
242 | complete(sub_info->complete); | 242 | complete(sub_info->complete); |
243 | } | 243 | } |
244 | } | 244 | } |