aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/kgdb.c
diff options
context:
space:
mode:
authorJason Wessel <jason.wessel@windriver.com>2010-04-02 12:33:29 -0400
committerJason Wessel <jason.wessel@windriver.com>2010-04-02 15:58:17 -0400
commita0279bd58060ccedbd414edf97d50cfa3778c370 (patch)
treeaf70474c8f284ce4a0429b22417699fa7b40e9a5 /kernel/kgdb.c
parent42be79e37e264557f12860fa4cc84b4de3685954 (diff)
kgdb: have ebin2mem call probe_kernel_write once
Rather than call probe_kernel_write() one byte at a time, process the whole buffer locally and pass the entire result in one go. This way, architectures that need to do special handling based on the length can do so, or we only end up calling memcpy() once. [sonic.zhang@analog.com: Reported original problem and preliminary patch] Signed-off-by: Jason Wessel <jason.wessel@windriver.com> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'kernel/kgdb.c')
-rw-r--r--kernel/kgdb.c23
1 files changed, 9 insertions, 14 deletions
diff --git a/kernel/kgdb.c b/kernel/kgdb.c
index 761fdd2b303..42fd128127a 100644
--- a/kernel/kgdb.c
+++ b/kernel/kgdb.c
@@ -391,27 +391,22 @@ int kgdb_mem2hex(char *mem, char *buf, int count)
391 391
392/* 392/*
393 * Copy the binary array pointed to by buf into mem. Fix $, #, and 393 * Copy the binary array pointed to by buf into mem. Fix $, #, and
394 * 0x7d escaped with 0x7d. Return a pointer to the character after 394 * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
395 * the last byte written. 395 * The input buf is overwitten with the result to write to mem.
396 */ 396 */
397static int kgdb_ebin2mem(char *buf, char *mem, int count) 397static int kgdb_ebin2mem(char *buf, char *mem, int count)
398{ 398{
399 int err = 0; 399 int size = 0;
400 char c; 400 char *c = buf;
401 401
402 while (count-- > 0) { 402 while (count-- > 0) {
403 c = *buf++; 403 c[size] = *buf++;
404 if (c == 0x7d) 404 if (c[size] == 0x7d)
405 c = *buf++ ^ 0x20; 405 c[size] = *buf++ ^ 0x20;
406 406 size++;
407 err = probe_kernel_write(mem, &c, 1);
408 if (err)
409 break;
410
411 mem++;
412 } 407 }
413 408
414 return err; 409 return probe_kernel_write(mem, c, size);
415} 410}
416 411
417/* 412/*