diff options
author | Yinghai Lu <yhlu.kernel@gmail.com> | 2008-08-19 23:50:11 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-10-16 10:52:33 -0400 |
commit | 2c6927a38f65b53b62f86158fba29a068c4e8b6a (patch) | |
tree | 4f23cf5689c8fbaed771219b4afd3f785d8048bc /kernel/irq/proc.c | |
parent | 9059d8fa4a3a9153da53da890039f7f956cc9d19 (diff) |
irq: replace loop with nr_irqs with for_each_irq_desc
There are a handful of loops that go from 0 to nr_irqs and use
get_irq_desc() on them. These would allocate all the irq_desc
entries, regardless of the need for them.
Use the smarter for_each_irq_desc() iterator that will only iterate
over the present ones.
v2: make sure arch without GENERIC_HARDIRQS work too
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/irq/proc.c')
-rw-r--r-- | kernel/irq/proc.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index c2f356c808f..bc0993d86c8 100644 --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c | |||
@@ -182,11 +182,10 @@ void register_handler_proc(unsigned int irq, struct irqaction *action) | |||
182 | 182 | ||
183 | #define MAX_NAMELEN 10 | 183 | #define MAX_NAMELEN 10 |
184 | 184 | ||
185 | void register_irq_proc(unsigned int irq) | 185 | void register_irq_proc(unsigned int irq, struct irq_desc *desc) |
186 | { | 186 | { |
187 | char name [MAX_NAMELEN]; | 187 | char name [MAX_NAMELEN]; |
188 | struct proc_dir_entry *entry; | 188 | struct proc_dir_entry *entry; |
189 | struct irq_desc *desc = irq_to_desc(irq); | ||
190 | 189 | ||
191 | if (!root_irq_dir || (desc->chip == &no_irq_chip) || desc->dir) | 190 | if (!root_irq_dir || (desc->chip == &no_irq_chip) || desc->dir) |
192 | return; | 191 | return; |
@@ -230,7 +229,8 @@ void register_default_affinity_proc(void) | |||
230 | 229 | ||
231 | void init_irq_proc(void) | 230 | void init_irq_proc(void) |
232 | { | 231 | { |
233 | int i; | 232 | unsigned int irq; |
233 | struct irq_desc *desc; | ||
234 | 234 | ||
235 | /* create /proc/irq */ | 235 | /* create /proc/irq */ |
236 | root_irq_dir = proc_mkdir("irq", NULL); | 236 | root_irq_dir = proc_mkdir("irq", NULL); |
@@ -242,7 +242,7 @@ void init_irq_proc(void) | |||
242 | /* | 242 | /* |
243 | * Create entries for all existing IRQs. | 243 | * Create entries for all existing IRQs. |
244 | */ | 244 | */ |
245 | for (i = 0; i < nr_irqs; i++) | 245 | for_each_irq_desc(irq, desc) |
246 | register_irq_proc(i); | 246 | register_irq_proc(irq, desc); |
247 | } | 247 | } |
248 | 248 | ||