diff options
author | Vlad Yasevich <vladislav.yasevich@hp.com> | 2009-03-24 12:24:51 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-03-24 22:49:11 -0400 |
commit | b2f5e7cd3dee2ed721bf0675e1a1ddebb849aee6 (patch) | |
tree | a7b48c260a3cb0050ad6198c6a50b52b318dfcb8 /include/net | |
parent | 63d9950b08184e6531adceb65f64b429909cc101 (diff) |
ipv6: Fix conflict resolutions during ipv6 binding
The ipv6 version of bind_conflict code calls ipv6_rcv_saddr_equal()
which at times wrongly identified intersections between addresses.
It particularly broke down under a few instances and caused erroneous
bind conflicts.
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net')
-rw-r--r-- | include/net/addrconf.h | 4 | ||||
-rw-r--r-- | include/net/udp.h | 2 |
2 files changed, 4 insertions, 2 deletions
diff --git a/include/net/addrconf.h b/include/net/addrconf.h index c216de528b0..7b55ab215a6 100644 --- a/include/net/addrconf.h +++ b/include/net/addrconf.h | |||
@@ -88,8 +88,8 @@ extern int ipv6_dev_get_saddr(struct net *net, | |||
88 | extern int ipv6_get_lladdr(struct net_device *dev, | 88 | extern int ipv6_get_lladdr(struct net_device *dev, |
89 | struct in6_addr *addr, | 89 | struct in6_addr *addr, |
90 | unsigned char banned_flags); | 90 | unsigned char banned_flags); |
91 | extern int ipv6_rcv_saddr_equal(const struct sock *sk, | 91 | extern int ipv6_rcv_saddr_equal(const struct sock *sk, |
92 | const struct sock *sk2); | 92 | const struct sock *sk2); |
93 | extern void addrconf_join_solict(struct net_device *dev, | 93 | extern void addrconf_join_solict(struct net_device *dev, |
94 | struct in6_addr *addr); | 94 | struct in6_addr *addr); |
95 | extern void addrconf_leave_solict(struct inet6_dev *idev, | 95 | extern void addrconf_leave_solict(struct inet6_dev *idev, |
diff --git a/include/net/udp.h b/include/net/udp.h index 90e6ce56be6..93dbe294d45 100644 --- a/include/net/udp.h +++ b/include/net/udp.h | |||
@@ -124,6 +124,8 @@ static inline void udp_lib_close(struct sock *sk, long timeout) | |||
124 | sk_common_release(sk); | 124 | sk_common_release(sk); |
125 | } | 125 | } |
126 | 126 | ||
127 | extern int ipv4_rcv_saddr_equal(const struct sock *sk1, | ||
128 | const struct sock *sk2); | ||
127 | extern int udp_lib_get_port(struct sock *sk, unsigned short snum, | 129 | extern int udp_lib_get_port(struct sock *sk, unsigned short snum, |
128 | int (*)(const struct sock*,const struct sock*)); | 130 | int (*)(const struct sock*,const struct sock*)); |
129 | 131 | ||