diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-01-02 10:12:50 -0500 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-01-02 10:12:50 -0500 |
commit | 201bffa46466b4afdf7d29db8eca3fa5decb39c8 (patch) | |
tree | 47e7d85563690547b67748092e587be1f31046b5 /include/linux/ide.h | |
parent | 631de3708d595d153e8a510a3608689290f4c0ed (diff) |
ide: use per-device request queue locks (v2)
* Move hack for flush requests from choose_drive() to do_ide_request().
* Add ide_plug_device() helper and convert core IDE code from using
per-hwgroup lock as a request lock to use the ->queue_lock instead.
* Remove no longer needed:
- choose_drive() function
- WAKEUP() macro
- 'sleeping' flag from ide_hwif_t
- 'service_{start,time}' fields from ide_drive_t
This patch results in much simpler and more maintainable code
(besides being a scalability improvement).
v2:
* Fixes/improvements based on review from Elias:
- take as many requests off the queue as possible
- remove now redundant BUG_ON()
Cc: Elias Oltmanns <eo@nebensachen.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'include/linux/ide.h')
-rw-r--r-- | include/linux/ide.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/include/linux/ide.h b/include/linux/ide.h index f408d6123f1..5f86ad40ee7 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h | |||
@@ -603,8 +603,6 @@ struct ide_drive_s { | |||
603 | unsigned long dev_flags; | 603 | unsigned long dev_flags; |
604 | 604 | ||
605 | unsigned long sleep; /* sleep until this time */ | 605 | unsigned long sleep; /* sleep until this time */ |
606 | unsigned long service_start; /* time we started last request */ | ||
607 | unsigned long service_time; /* service time of last request */ | ||
608 | unsigned long timeout; /* max time to wait for irq */ | 606 | unsigned long timeout; /* max time to wait for irq */ |
609 | 607 | ||
610 | special_t special; /* special action flags */ | 608 | special_t special; /* special action flags */ |
@@ -872,8 +870,6 @@ typedef struct hwgroup_s { | |||
872 | 870 | ||
873 | /* BOOL: protects all fields below */ | 871 | /* BOOL: protects all fields below */ |
874 | volatile int busy; | 872 | volatile int busy; |
875 | /* BOOL: wake us up on timer expiry */ | ||
876 | unsigned int sleeping : 1; | ||
877 | /* BOOL: polling active & poll_timeout field valid */ | 873 | /* BOOL: polling active & poll_timeout field valid */ |
878 | unsigned int polling : 1; | 874 | unsigned int polling : 1; |
879 | 875 | ||