diff options
author | Theodore Ts'o <tytso@mit.edu> | 2009-09-17 08:32:22 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2009-09-17 08:32:22 -0400 |
commit | 1b9c12f44c1eb614fd3b8822bfe8f1f5d8e53737 (patch) | |
tree | 5de0737dd71557dadaa5e3f98d6e62bd3b9d7c51 /fs/ext4/inode.c | |
parent | fb0a387dcdcd21aab1b09ee7fd80b7c979bdbbfd (diff) |
ext4: store EXT4_EXT_MIGRATE in i_state instead of i_flags
EXT4_EXT_MIGRATE is only intended to be used for an in-memory flag,
and the hex value assigned to it collides with FS_DIRECTIO_FL (which
is also stored in i_flags). There's no reason for the
EXT4_EXT_MIGRATE bit to be stored in i_flags, so we switch it to use
i_state instead.
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/inode.c')
-rw-r--r-- | fs/ext4/inode.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 5a8979259c9..a5b4ce40cc6 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -1255,8 +1255,7 @@ int ext4_get_blocks(handle_t *handle, struct inode *inode, sector_t block, | |||
1255 | * i_data's format changing. Force the migrate | 1255 | * i_data's format changing. Force the migrate |
1256 | * to fail by clearing migrate flags | 1256 | * to fail by clearing migrate flags |
1257 | */ | 1257 | */ |
1258 | EXT4_I(inode)->i_flags = EXT4_I(inode)->i_flags & | 1258 | EXT4_I(inode)->i_state &= ~EXT4_STATE_EXT_MIGRATE; |
1259 | ~EXT4_EXT_MIGRATE; | ||
1260 | } | 1259 | } |
1261 | } | 1260 | } |
1262 | 1261 | ||
@@ -4596,8 +4595,7 @@ static int ext4_do_update_inode(handle_t *handle, | |||
4596 | if (ext4_inode_blocks_set(handle, raw_inode, ei)) | 4595 | if (ext4_inode_blocks_set(handle, raw_inode, ei)) |
4597 | goto out_brelse; | 4596 | goto out_brelse; |
4598 | raw_inode->i_dtime = cpu_to_le32(ei->i_dtime); | 4597 | raw_inode->i_dtime = cpu_to_le32(ei->i_dtime); |
4599 | /* clear the migrate flag in the raw_inode */ | 4598 | raw_inode->i_flags = cpu_to_le32(ei->i_flags); |
4600 | raw_inode->i_flags = cpu_to_le32(ei->i_flags & ~EXT4_EXT_MIGRATE); | ||
4601 | if (EXT4_SB(inode->i_sb)->s_es->s_creator_os != | 4599 | if (EXT4_SB(inode->i_sb)->s_es->s_creator_os != |
4602 | cpu_to_le32(EXT4_OS_HURD)) | 4600 | cpu_to_le32(EXT4_OS_HURD)) |
4603 | raw_inode->i_file_acl_high = | 4601 | raw_inode->i_file_acl_high = |