diff options
author | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2011-04-04 03:02:53 -0400 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2011-05-11 07:10:54 -0400 |
commit | a9a6500b718a38d4658b8a61edd8fc3aa0418b50 (patch) | |
tree | 68d106aa4fb167d25be15ef24dbedce17802cb0e /drivers | |
parent | b2765092aed717ef9fd14bf5f82024359aff0576 (diff) |
OMAP: DSS2: DSI: fix dsi_dump_clocks()
On OMAP4, reading DSI_PLL_CONFIGURATION2 register requires the L3 clock
(CIO_CLK_ICG) to PLL. Currently dsi_dump_clocks() tries to read that
register without enabling the L3 clock, leading to crash if DSI is not
in use.
The status of the bit being read from DSI_PLL_CONFIGURATION2 is
available from dsi_clock_info->use_sys_clk, so we can avoid the whole
problem by just using that.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/video/omap2/dss/dsi.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c index ed7f17d5db0..5cf13f4b9e8 100644 --- a/drivers/video/omap2/dss/dsi.c +++ b/drivers/video/omap2/dss/dsi.c | |||
@@ -1491,7 +1491,6 @@ void dsi_pll_uninit(void) | |||
1491 | 1491 | ||
1492 | void dsi_dump_clocks(struct seq_file *s) | 1492 | void dsi_dump_clocks(struct seq_file *s) |
1493 | { | 1493 | { |
1494 | int clksel; | ||
1495 | struct dsi_clock_info *cinfo = &dsi.current_cinfo; | 1494 | struct dsi_clock_info *cinfo = &dsi.current_cinfo; |
1496 | enum dss_clk_source dispc_clk_src, dsi_clk_src; | 1495 | enum dss_clk_source dispc_clk_src, dsi_clk_src; |
1497 | 1496 | ||
@@ -1500,13 +1499,10 @@ void dsi_dump_clocks(struct seq_file *s) | |||
1500 | 1499 | ||
1501 | enable_clocks(1); | 1500 | enable_clocks(1); |
1502 | 1501 | ||
1503 | clksel = REG_GET(DSI_PLL_CONFIGURATION2, 11, 11); | ||
1504 | |||
1505 | seq_printf(s, "- DSI PLL -\n"); | 1502 | seq_printf(s, "- DSI PLL -\n"); |
1506 | 1503 | ||
1507 | seq_printf(s, "dsi pll source = %s\n", | 1504 | seq_printf(s, "dsi pll source = %s\n", |
1508 | clksel == 0 ? | 1505 | cinfo->use_sys_clk ? "dss_sys_clk" : "pclkfree"); |
1509 | "dss_sys_clk" : "pclkfree"); | ||
1510 | 1506 | ||
1511 | seq_printf(s, "Fint\t\t%-16luregn %u\n", cinfo->fint, cinfo->regn); | 1507 | seq_printf(s, "Fint\t\t%-16luregn %u\n", cinfo->fint, cinfo->regn); |
1512 | 1508 | ||