diff options
author | Antonino A. Daplas <adaplas@gmail.com> | 2006-03-11 06:27:23 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-11 12:19:35 -0500 |
commit | 98365f5eb47e23d6ac1244da556984a74260021e (patch) | |
tree | 033e9f8ad33c168a6381fa41a082aedf4d0182c8 /drivers | |
parent | 939205b27312b7d7c4c55624ba785e554b39ecbb (diff) |
[PATCH] s1d13xxxfb: Fix resource leak
struct info may not be released in the driver's error path.
Coverity Bug 672
Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/video/s1d13xxxfb.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/video/s1d13xxxfb.c b/drivers/video/s1d13xxxfb.c index e5d0f92eeae..feec47bdd47 100644 --- a/drivers/video/s1d13xxxfb.c +++ b/drivers/video/s1d13xxxfb.c | |||
@@ -588,6 +588,7 @@ s1d13xxxfb_probe(struct platform_device *pdev) | |||
588 | goto bail; | 588 | goto bail; |
589 | } | 589 | } |
590 | 590 | ||
591 | platform_set_drvdata(pdev, info); | ||
591 | default_par = info->par; | 592 | default_par = info->par; |
592 | default_par->regs = ioremap_nocache(pdev->resource[1].start, | 593 | default_par->regs = ioremap_nocache(pdev->resource[1].start, |
593 | pdev->resource[1].end - pdev->resource[1].start +1); | 594 | pdev->resource[1].end - pdev->resource[1].start +1); |
@@ -638,8 +639,6 @@ s1d13xxxfb_probe(struct platform_device *pdev) | |||
638 | goto bail; | 639 | goto bail; |
639 | } | 640 | } |
640 | 641 | ||
641 | platform_set_drvdata(pdev, info); | ||
642 | |||
643 | printk(KERN_INFO "fb%d: %s frame buffer device\n", | 642 | printk(KERN_INFO "fb%d: %s frame buffer device\n", |
644 | info->node, info->fix.id); | 643 | info->node, info->fix.id); |
645 | 644 | ||