aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorTushar Dave <tushar.n.dave@intel.com>2012-07-30 22:02:43 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-08-15 15:04:30 -0400
commit5a4cebe94b76a0182a8ebb97b665ff84e7427482 (patch)
tree59d098069f3a185d1d85fa944abe9e43ff42b2df /drivers
parent4f5a5866aa4dccf42b2fa1cdecf372025a3e86cc (diff)
e1000e: NIC goes up and immediately goes down
commit b7ec70be01a87f2c85df3ae11046e74f9b67e323 upstream. Found that commit d478eb44 was a bad commit. If the link partner is transmitting codeword (even if NULL codeword), then the RXCW.C bit will be set so check for RXCW.CW is unnecessary. Ref: RH BZ 840642 Reported-by: Fabio Futigami <ffutigam@redhat.com> Signed-off-by: Tushar Dave <tushar.n.dave@intel.com> CC: Marcelo Ricardo Leitner <mleitner@redhat.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/e1000e/82571.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c
index 5278e8456b6..0d0ee552d95 100644
--- a/drivers/net/e1000e/82571.c
+++ b/drivers/net/e1000e/82571.c
@@ -1602,10 +1602,8 @@ static s32 e1000_check_for_serdes_link_82571(struct e1000_hw *hw)
1602 * auto-negotiation in the TXCW register and disable 1602 * auto-negotiation in the TXCW register and disable
1603 * forced link in the Device Control register in an 1603 * forced link in the Device Control register in an
1604 * attempt to auto-negotiate with our link partner. 1604 * attempt to auto-negotiate with our link partner.
1605 * If the partner code word is null, stop forcing
1606 * and restart auto negotiation.
1607 */ 1605 */
1608 if ((rxcw & E1000_RXCW_C) || !(rxcw & E1000_RXCW_CW)) { 1606 if (rxcw & E1000_RXCW_C) {
1609 /* Enable autoneg, and unforce link up */ 1607 /* Enable autoneg, and unforce link up */
1610 ew32(TXCW, mac->txcw); 1608 ew32(TXCW, mac->txcw);
1611 ew32(CTRL, (ctrl & ~E1000_CTRL_SLU)); 1609 ew32(CTRL, (ctrl & ~E1000_CTRL_SLU));