diff options
author | Alexey Charkov <alchark@gmail.com> | 2010-12-20 08:03:14 -0500 |
---|---|---|
committer | Paul Mundt <lethal@linux-sh.org> | 2010-12-20 11:05:43 -0500 |
commit | a7f53284e97af9670a68993c31f61a4e62a19ea5 (patch) | |
tree | 9469611835d11654197d671537535b4425a6cfea /drivers/video/wmt_ge_rops.c | |
parent | 521bc83b0fcda6f323f1de0e7bf137401a8145a2 (diff) |
fbdev: Minor cleanup in WM8505-related code
This replaces the last remaining driver name reference with the
macro for uniformity in wm8505fb.
In addition, the error return path in wmt_ge_rops.c is made more
uniform by getting rid of goto's in remaining places.
Signed-off-by: Alexey Charkov <alchark@gmail.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'drivers/video/wmt_ge_rops.c')
-rw-r--r-- | drivers/video/wmt_ge_rops.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/video/wmt_ge_rops.c b/drivers/video/wmt_ge_rops.c index f31883f8eaf..45832b7ef7d 100644 --- a/drivers/video/wmt_ge_rops.c +++ b/drivers/video/wmt_ge_rops.c | |||
@@ -127,13 +127,11 @@ EXPORT_SYMBOL_GPL(wmt_ge_sync); | |||
127 | static int __devinit wmt_ge_rops_probe(struct platform_device *pdev) | 127 | static int __devinit wmt_ge_rops_probe(struct platform_device *pdev) |
128 | { | 128 | { |
129 | struct resource *res; | 129 | struct resource *res; |
130 | int ret; | ||
131 | 130 | ||
132 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | 131 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
133 | if (res == NULL) { | 132 | if (res == NULL) { |
134 | dev_err(&pdev->dev, "no I/O memory resource defined\n"); | 133 | dev_err(&pdev->dev, "no I/O memory resource defined\n"); |
135 | ret = -ENODEV; | 134 | return -ENODEV; |
136 | goto error; | ||
137 | } | 135 | } |
138 | 136 | ||
139 | /* Only one ROP engine is presently supported. */ | 137 | /* Only one ROP engine is presently supported. */ |
@@ -145,17 +143,13 @@ static int __devinit wmt_ge_rops_probe(struct platform_device *pdev) | |||
145 | regbase = ioremap(res->start, resource_size(res)); | 143 | regbase = ioremap(res->start, resource_size(res)); |
146 | if (regbase == NULL) { | 144 | if (regbase == NULL) { |
147 | dev_err(&pdev->dev, "failed to map I/O memory\n"); | 145 | dev_err(&pdev->dev, "failed to map I/O memory\n"); |
148 | ret = -EBUSY; | 146 | return -EBUSY; |
149 | goto error; | ||
150 | } | 147 | } |
151 | 148 | ||
152 | writel(1, regbase + GE_ENABLE_OFF); | 149 | writel(1, regbase + GE_ENABLE_OFF); |
153 | printk(KERN_INFO "Enabled support for WMT GE raster acceleration\n"); | 150 | printk(KERN_INFO "Enabled support for WMT GE raster acceleration\n"); |
154 | 151 | ||
155 | return 0; | 152 | return 0; |
156 | |||
157 | error: | ||
158 | return ret; | ||
159 | } | 153 | } |
160 | 154 | ||
161 | static int __devexit wmt_ge_rops_remove(struct platform_device *pdev) | 155 | static int __devexit wmt_ge_rops_remove(struct platform_device *pdev) |