[PATCH] fbcon/fbdev: Move softcursor out of fbdev to fbcon

According to Jon Smirl, filling in the field fb_cursor with soft_cursor for
drivers that do not support hardware cursors is redundant.  The soft_cursor
function is usable by all drivers because it is just a wrapper around
fb_imageblit.  And because soft_cursor is an fbcon-specific hook, the file is
moved to the console directory.

Thus, drivers that do not support hardware cursors can leave the fb_cursor
field blank.  For drivers that do, they can fill up this field with their own
version.

The end result is a smaller code size.  And if the framebuffer console is not
loaded, module/kernel size is also reduced because the soft_cursor module will
also not be loaded.

Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

1 files changed, 3 insertions, 6 deletions

diff --git a/drivers/video/skeletonfb.c b/drivers/video/skeletonfb.c
index 7b43716ab66..a01e7ecc15e 100644
--- a/drivers/video/skeletonfb.c
+++ b/drivers/video/skeletonfb.c
@@ -457,11 +457,8 @@ void xxxfb_imageblit(struct fb_info *p, const struct fb_image *image)
 }
 
 /**
- *      xxxfb_cursor -  REQUIRED function. If your hardware lacks support
- *                      for a cursor you can use the default cursor whose
- *                      function is called soft_cursor. It will always 
- *                      work since it uses xxxfb_imageblit function which 
- *                      is required.             
+ *      xxxfb_cursor -  OPTIONAL. If your hardware lacks support
+ *                      for a cursor, leave this field NULL.
  *
  *      @info: frame buffer structure that represents a single frame buffer
  *      @cursor: structure defining the cursor to draw.
@@ -663,7 +660,7 @@ static struct fb_ops xxxfb_ops = {
         .fb_fillrect    = xxxfb_fillrect,       /* Needed !!! */ 
         .fb_copyarea    = xxxfb_copyarea,       /* Needed !!! */ 
         .fb_imageblit   = xxxfb_imageblit,      /* Needed !!! */
-        .fb_cursor      = xxxfb_cursor,         /* Needed !!! */
+        .fb_cursor      = xxxfb_cursor,         /* Optional !!! */
         .fb_rotate      = xxxfb_rotate,
         .fb_poll        = xxxfb_poll,
         .fb_sync        = xxxfb_sync,