diff options
author | Thomas Faber <thfabba@gmx.de> | 2012-03-02 03:41:50 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-02 12:26:52 -0400 |
commit | 168421aba8d57a7798c9a6ec2493ff6fa4b3cbae (patch) | |
tree | 169d4262b1f03556a3879a7f0cd7e4578f5eab08 /drivers/usb/gadget | |
parent | 46070382f1745a7ada312fd0db4dff722eb4f52d (diff) |
usb: gadgetfs: return number of bytes on ep0 read request
commit 85b4b3c8c189e0159101f7628a71411af072ff69 upstream.
A read from GadgetFS endpoint 0 during the data stage of a control
request would always return 0 on success (as returned by
wait_event_interruptible) despite having written data into the user
buffer.
This patch makes it correctly set the return value to the number of
bytes read.
Signed-off-by: Thomas Faber <thfabba@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget')
-rw-r--r-- | drivers/usb/gadget/inode.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c index a56876aaf76..febadaa2a80 100644 --- a/drivers/usb/gadget/inode.c +++ b/drivers/usb/gadget/inode.c | |||
@@ -1050,6 +1050,8 @@ ep0_read (struct file *fd, char __user *buf, size_t len, loff_t *ptr) | |||
1050 | // FIXME don't call this with the spinlock held ... | 1050 | // FIXME don't call this with the spinlock held ... |
1051 | if (copy_to_user (buf, dev->req->buf, len)) | 1051 | if (copy_to_user (buf, dev->req->buf, len)) |
1052 | retval = -EFAULT; | 1052 | retval = -EFAULT; |
1053 | else | ||
1054 | retval = len; | ||
1053 | clean_req (dev->gadget->ep0, dev->req); | 1055 | clean_req (dev->gadget->ep0, dev->req); |
1054 | /* NOTE userspace can't yet choose to stall */ | 1056 | /* NOTE userspace can't yet choose to stall */ |
1055 | } | 1057 | } |