diff options
| author | Claudio Scordino <claudio@evidence.eu.com> | 2011-12-16 09:08:49 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2012-01-12 14:35:07 -0500 |
| commit | 630fe244a944ebb950e8b2076177547266d255cf (patch) | |
| tree | aae7e78232a9e9f024e0a48add044751a2048ac1 /drivers/tty | |
| parent | 90a043b02598d19b6dccc677bbf9bb8e8ec94ab7 (diff) | |
atmel_serial: fix spinlock lockup in RS485 code
commit dbf1115d3f8c7052788aa4e6e46abd27f3b3eeba upstream.
Patch to fix a spinlock lockup in the driver that sometimes happens when the
tasklet starts.
Signed-off-by: Claudio Scordino <claudio@evidence.eu.com>
Signed-off-by: Dave Bender <codehero@gmail.com>
Tested-by: Dave Bender <codehero@gmail.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/serial/atmel_serial.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index af9b7814965..b989495c763 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c | |||
| @@ -199,8 +199,9 @@ void atmel_config_rs485(struct uart_port *port, struct serial_rs485 *rs485conf) | |||
| 199 | { | 199 | { |
| 200 | struct atmel_uart_port *atmel_port = to_atmel_uart_port(port); | 200 | struct atmel_uart_port *atmel_port = to_atmel_uart_port(port); |
| 201 | unsigned int mode; | 201 | unsigned int mode; |
| 202 | unsigned long flags; | ||
| 202 | 203 | ||
| 203 | spin_lock(&port->lock); | 204 | spin_lock_irqsave(&port->lock, flags); |
| 204 | 205 | ||
| 205 | /* Disable interrupts */ | 206 | /* Disable interrupts */ |
| 206 | UART_PUT_IDR(port, atmel_port->tx_done_mask); | 207 | UART_PUT_IDR(port, atmel_port->tx_done_mask); |
| @@ -231,7 +232,7 @@ void atmel_config_rs485(struct uart_port *port, struct serial_rs485 *rs485conf) | |||
| 231 | /* Enable interrupts */ | 232 | /* Enable interrupts */ |
| 232 | UART_PUT_IER(port, atmel_port->tx_done_mask); | 233 | UART_PUT_IER(port, atmel_port->tx_done_mask); |
| 233 | 234 | ||
| 234 | spin_unlock(&port->lock); | 235 | spin_unlock_irqrestore(&port->lock, flags); |
| 235 | 236 | ||
| 236 | } | 237 | } |
| 237 | 238 | ||
