diff options
author | Ingo Molnar <mingo@elte.hu> | 2008-01-02 11:25:34 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-01-02 16:11:06 -0500 |
commit | ac40532ef0b8649e6f7f83859ea0de1c4ed08a19 (patch) | |
tree | ca86d577fe7fe68ae28b7f7d020f86bc9fff5535 /drivers/scsi/scsi_error.c | |
parent | 158a962422e4a54dc256b6a9b9562f3d30d34d9c (diff) |
scsi: revert "[SCSI] Get rid of scsi_cmnd->done"
This reverts commit 6f5391c283d7fdcf24bf40786ea79061919d1e1d ("[SCSI]
Get rid of scsi_cmnd->done") that was supposed to be a cleanup commit,
but apparently it causes regressions:
Bug 9370 - v2.6.24-rc2-409-g9418d5d: attempt to access beyond end of device
http://bugzilla.kernel.org/show_bug.cgi?id=9370
this patch should be reintroduced in a more split-up form to make
testing of it easier.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Matthew Wilcox <matthew@wil.cx>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/scsi/scsi_error.c')
-rw-r--r-- | drivers/scsi/scsi_error.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index ebaca4ca4a1..70700b97c91 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c | |||
@@ -1699,6 +1699,7 @@ scsi_reset_provider(struct scsi_device *dev, int flag) | |||
1699 | memset(&scmd->cmnd, '\0', sizeof(scmd->cmnd)); | 1699 | memset(&scmd->cmnd, '\0', sizeof(scmd->cmnd)); |
1700 | 1700 | ||
1701 | scmd->scsi_done = scsi_reset_provider_done_command; | 1701 | scmd->scsi_done = scsi_reset_provider_done_command; |
1702 | scmd->done = NULL; | ||
1702 | scmd->request_buffer = NULL; | 1703 | scmd->request_buffer = NULL; |
1703 | scmd->request_bufflen = 0; | 1704 | scmd->request_bufflen = 0; |
1704 | 1705 | ||