[SCSI] qla2xxx: Consolidate ISP24xx chip reset logic.

Consolidate ISP24xx chip reset logic.

Consolidate near-duplicate RISC reset logic from
qla24xx_reset_chip() and qla24xx_chip_diag().  Also, after
initiating a soft-reset, insure the firmware has completed
all NVRAM accesses before continuing.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

2 files changed, 42 insertions, 47 deletions

diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c
index a20450e9a47..72bbaa91dc7 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.c
+++ b/drivers/scsi/qla2xxx/qla_dbg.c
@@ -1526,6 +1526,17 @@ qla24xx_fw_dump(scsi_qla_host_t *ha, int hardware_locked)
 
                 WRT_REG_DWORD(&reg->ctrl_status,
                     CSRX_ISP_SOFT_RESET|CSRX_DMA_SHUTDOWN|MWB_4096_BYTES);
+                RD_REG_DWORD(&reg->ctrl_status);
+
+                /* Wait for firmware to complete NVRAM accesses. */
+                udelay(5);
+                mb[0] = (uint32_t) RD_REG_WORD(&reg->mailbox0);
+                for (cnt = 10000 ; cnt && mb[0]; cnt--) {
+                        udelay(5);
+                        mb[0] = (uint32_t) RD_REG_WORD(&reg->mailbox0);
+                        barrier();
+                }
+
                 udelay(20);
                 for (cnt = 0; cnt < 30000; cnt++) {
                         if ((RD_REG_DWORD(&reg->ctrl_status) &
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 3fd63804319..1a25714e85c 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -564,20 +564,18 @@ qla2x00_reset_chip(scsi_qla_host_t *ha)
 }
 
 /**
- * qla24xx_reset_chip() - Reset ISP24xx chip.
+ * qla24xx_reset_risc() - Perform full reset of ISP24xx RISC.
  * @ha: HA context
  *
  * Returns 0 on success.
  */
-void
-qla24xx_reset_chip(scsi_qla_host_t *ha)
+static inline void
+qla24xx_reset_risc(scsi_qla_host_t *ha)
 {
         unsigned long flags = 0;
         struct device_reg_24xx __iomem *reg = &ha->iobase->isp24;
         uint32_t cnt, d2;
 
-        ha->isp_ops.disable_intrs(ha);
-
         spin_lock_irqsave(&ha->hardware_lock, flags);
 
         /* Reset RISC. */
@@ -591,6 +589,17 @@ qla24xx_reset_chip(scsi_qla_host_t *ha)
 
         WRT_REG_DWORD(&reg->ctrl_status,
             CSRX_ISP_SOFT_RESET|CSRX_DMA_SHUTDOWN|MWB_4096_BYTES);
+        RD_REG_DWORD(&reg->ctrl_status);
+
+        /* Wait for firmware to complete NVRAM accesses. */
+        udelay(5);
+        d2 = (uint32_t) RD_REG_WORD(&reg->mailbox0);
+        for (cnt = 10000 ; cnt && d2; cnt--) {
+                udelay(5);
+                d2 = (uint32_t) RD_REG_WORD(&reg->mailbox0);
+                barrier();
+        }
+
         udelay(20);
         d2 = RD_REG_DWORD(&reg->ctrl_status);
         for (cnt = 6000000 ; cnt && (d2 & CSRX_ISP_SOFT_RESET); cnt--) {
@@ -619,6 +628,21 @@ qla24xx_reset_chip(scsi_qla_host_t *ha)
 }
 
 /**
+ * qla24xx_reset_chip() - Reset ISP24xx chip.
+ * @ha: HA context
+ *
+ * Returns 0 on success.
+ */
+void
+qla24xx_reset_chip(scsi_qla_host_t *ha)
+{
+        ha->isp_ops.disable_intrs(ha);
+
+        /* Perform RISC reset. */
+        qla24xx_reset_risc(ha);
+}
+
+/**
  * qla2x00_chip_diag() - Test chip for proper operation.
  * @ha: HA context
  *
@@ -753,49 +777,9 @@ int
 qla24xx_chip_diag(scsi_qla_host_t *ha)
 {
         int rval;
-        struct device_reg_24xx __iomem *reg = &ha->iobase->isp24;
-        unsigned long flags = 0;
-        uint32_t cnt, d2;
-
-        spin_lock_irqsave(&ha->hardware_lock, flags);
 
-        /* Reset RISC. */
-        WRT_REG_DWORD(&reg->ctrl_status, CSRX_DMA_SHUTDOWN|MWB_4096_BYTES);
-        for (cnt = 0; cnt < 30000; cnt++) {
-                if ((RD_REG_DWORD(&reg->ctrl_status) &
-                    CSRX_DMA_ACTIVE) == 0)
-                        break;
-
-                udelay(10);
-        }
-
-        WRT_REG_DWORD(&reg->ctrl_status,
-            CSRX_ISP_SOFT_RESET|CSRX_DMA_SHUTDOWN|MWB_4096_BYTES);
-        udelay(20);
-        d2 = RD_REG_DWORD(&reg->ctrl_status);
-        for (cnt = 6000000 ; cnt && (d2 & CSRX_ISP_SOFT_RESET); cnt--) {
-                udelay(5);
-                d2 = RD_REG_DWORD(&reg->ctrl_status);
-                barrier();
-        }
-
-        WRT_REG_DWORD(&reg->hccr, HCCRX_SET_RISC_RESET);
-        RD_REG_DWORD(&reg->hccr);
-
-        WRT_REG_DWORD(&reg->hccr, HCCRX_REL_RISC_PAUSE);
-        RD_REG_DWORD(&reg->hccr);
-
-        WRT_REG_DWORD(&reg->hccr, HCCRX_CLR_RISC_RESET);
-        RD_REG_DWORD(&reg->hccr);
-
-        d2 = (uint32_t) RD_REG_WORD(&reg->mailbox0);
-        for (cnt = 6000000 ; cnt && d2; cnt--) {
-                udelay(5);
-                d2 = (uint32_t) RD_REG_WORD(&reg->mailbox0);
-                barrier();
-        }
-
-        spin_unlock_irqrestore(&ha->hardware_lock, flags);
+        /* Perform RISC reset. */
+        qla24xx_reset_risc(ha);
 
         ha->fw_transfer_size = REQUEST_ENTRY_SIZE * 1024;