diff options
author | Michal Schmidt <mschmidt@redhat.com> | 2010-05-11 05:44:54 -0400 |
---|---|---|
committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2010-05-11 15:01:11 -0400 |
commit | 447c5dd7338638f526e9bcf7dcf69b4da5835c7d (patch) | |
tree | 09385ef825cd7ddb27aff74f5857cbe8ddd903ad /drivers/pci/pci-sysfs.c | |
parent | 3196180a54b593838c0b6496e5b524a2f69bb190 (diff) |
PCI: return correct value when writing to the "reset" attribute
A successful write() to the "reset" sysfs attribute should return the
number of bytes written, not 0. Otherwise userspace (bash) retries the
write over and over again.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/pci/pci-sysfs.c')
-rw-r--r-- | drivers/pci/pci-sysfs.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 941e939d1da..89a08ed39c9 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c | |||
@@ -960,7 +960,12 @@ static ssize_t reset_store(struct device *dev, | |||
960 | 960 | ||
961 | if (val != 1) | 961 | if (val != 1) |
962 | return -EINVAL; | 962 | return -EINVAL; |
963 | return pci_reset_function(pdev); | 963 | |
964 | result = pci_reset_function(pdev); | ||
965 | if (result < 0) | ||
966 | return result; | ||
967 | |||
968 | return count; | ||
964 | } | 969 | } |
965 | 970 | ||
966 | static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store); | 971 | static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store); |