diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2007-02-10 04:45:54 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-11 13:51:32 -0500 |
commit | b653d081c17e26101980c858a9808740533b78b4 (patch) | |
tree | 907b6e6d97f30b61840cf4b1654f88a1df56945c /drivers/parisc/led.c | |
parent | 891dcd2f7ab15e2aaad07f6925b3a53fd8d5c02f (diff) |
[PATCH] proc: remove useless (and buggy) ->nlink settings
Bug: pnx8550 code creates directory but resets ->nlink to 1.
create_proc_entry() et al will correctly set ->nlink for you.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Corey Minyard <minyard@acm.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Greg KH <greg@kroah.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/parisc/led.c')
-rw-r--r-- | drivers/parisc/led.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c index 8dac2ba82bb..9a731c101d1 100644 --- a/drivers/parisc/led.c +++ b/drivers/parisc/led.c | |||
@@ -252,7 +252,6 @@ static int __init led_create_procfs(void) | |||
252 | proc_pdc_root->owner = THIS_MODULE; | 252 | proc_pdc_root->owner = THIS_MODULE; |
253 | ent = create_proc_entry("led", S_IFREG|S_IRUGO|S_IWUSR, proc_pdc_root); | 253 | ent = create_proc_entry("led", S_IFREG|S_IRUGO|S_IWUSR, proc_pdc_root); |
254 | if (!ent) return -1; | 254 | if (!ent) return -1; |
255 | ent->nlink = 1; | ||
256 | ent->data = (void *)LED_NOLCD; /* LED */ | 255 | ent->data = (void *)LED_NOLCD; /* LED */ |
257 | ent->read_proc = led_proc_read; | 256 | ent->read_proc = led_proc_read; |
258 | ent->write_proc = led_proc_write; | 257 | ent->write_proc = led_proc_write; |
@@ -262,7 +261,6 @@ static int __init led_create_procfs(void) | |||
262 | { | 261 | { |
263 | ent = create_proc_entry("lcd", S_IFREG|S_IRUGO|S_IWUSR, proc_pdc_root); | 262 | ent = create_proc_entry("lcd", S_IFREG|S_IRUGO|S_IWUSR, proc_pdc_root); |
264 | if (!ent) return -1; | 263 | if (!ent) return -1; |
265 | ent->nlink = 1; | ||
266 | ent->data = (void *)LED_HASLCD; /* LCD */ | 264 | ent->data = (void *)LED_HASLCD; /* LCD */ |
267 | ent->read_proc = led_proc_read; | 265 | ent->read_proc = led_proc_read; |
268 | ent->write_proc = led_proc_write; | 266 | ent->write_proc = led_proc_write; |