aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/iwlwifi/iwl-4965.c
diff options
context:
space:
mode:
authorWinkler, Tomas <tomas.winkler@intel.com>2008-12-18 21:37:33 -0500
committerJohn W. Linville <linville@tuxdriver.com>2009-01-29 15:59:17 -0500
commit15b1687cb4f45b87ddbe4dfc7759ff5bb69497d2 (patch)
treec4e3e70b0d9b7ba877e52cd0a5116c4411bbf8e1 /drivers/net/wireless/iwlwifi/iwl-4965.c
parent39aadf8c29ad959e823efca15381bea9d0770b1e (diff)
iwlwifi: replace IWL_ERROR with IWL_ERR
IWL_ERR doesn't use hidden priv pointer. Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Zhu Yi <yi.zhu@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/iwlwifi/iwl-4965.c')
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-4965.c32
1 files changed, 17 insertions, 15 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
index 3de8d641399..e68d587a44b 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
@@ -85,7 +85,7 @@ static int iwl4965_verify_bsm(struct iwl_priv *priv)
85 reg += sizeof(u32), image++) { 85 reg += sizeof(u32), image++) {
86 val = iwl_read_prph(priv, reg); 86 val = iwl_read_prph(priv, reg);
87 if (val != le32_to_cpu(*image)) { 87 if (val != le32_to_cpu(*image)) {
88 IWL_ERROR("BSM uCode verification failed at " 88 IWL_ERR(priv, "BSM uCode verification failed at "
89 "addr 0x%08X+%u (of %u), is 0x%x, s/b 0x%x\n", 89 "addr 0x%08X+%u (of %u), is 0x%x, s/b 0x%x\n",
90 BSM_SRAM_LOWER_BOUND, 90 BSM_SRAM_LOWER_BOUND,
91 reg - BSM_SRAM_LOWER_BOUND, len, 91 reg - BSM_SRAM_LOWER_BOUND, len,
@@ -203,7 +203,7 @@ static int iwl4965_load_bsm(struct iwl_priv *priv)
203 if (i < 100) 203 if (i < 100)
204 IWL_DEBUG_INFO("BSM write complete, poll %d iterations\n", i); 204 IWL_DEBUG_INFO("BSM write complete, poll %d iterations\n", i);
205 else { 205 else {
206 IWL_ERROR("BSM write did not complete!\n"); 206 IWL_ERR(priv, "BSM write did not complete!\n");
207 return -EIO; 207 return -EIO;
208 } 208 }
209 209
@@ -523,7 +523,8 @@ static void iwl4965_chain_noise_reset(struct iwl_priv *priv)
523 cmd.diff_gain_c = 0; 523 cmd.diff_gain_c = 0;
524 if (iwl_send_cmd_pdu(priv, REPLY_PHY_CALIBRATION_CMD, 524 if (iwl_send_cmd_pdu(priv, REPLY_PHY_CALIBRATION_CMD,
525 sizeof(cmd), &cmd)) 525 sizeof(cmd), &cmd))
526 IWL_ERROR("Could not send REPLY_PHY_CALIBRATION_CMD\n"); 526 IWL_ERR(priv,
527 "Could not send REPLY_PHY_CALIBRATION_CMD\n");
527 data->state = IWL_CHAIN_NOISE_ACCUMULATE; 528 data->state = IWL_CHAIN_NOISE_ACCUMULATE;
528 IWL_DEBUG_CALIB("Run chain_noise_calibrate\n"); 529 IWL_DEBUG_CALIB("Run chain_noise_calibrate\n");
529 } 530 }
@@ -804,8 +805,9 @@ static int iwl4965_hw_set_hw_params(struct iwl_priv *priv)
804 805
805 if ((priv->cfg->mod_params->num_of_queues > IWL49_NUM_QUEUES) || 806 if ((priv->cfg->mod_params->num_of_queues > IWL49_NUM_QUEUES) ||
806 (priv->cfg->mod_params->num_of_queues < IWL_MIN_NUM_QUEUES)) { 807 (priv->cfg->mod_params->num_of_queues < IWL_MIN_NUM_QUEUES)) {
807 IWL_ERROR("invalid queues_num, should be between %d and %d\n", 808 IWL_ERR(priv,
808 IWL_MIN_NUM_QUEUES, IWL49_NUM_QUEUES); 809 "invalid queues_num, should be between %d and %d\n",
810 IWL_MIN_NUM_QUEUES, IWL49_NUM_QUEUES);
809 return -EINVAL; 811 return -EINVAL;
810 } 812 }
811 813
@@ -955,7 +957,7 @@ static int iwl4965_interpolate_chan(struct iwl_priv *priv, u32 channel,
955 957
956 s = iwl4965_get_sub_band(priv, channel); 958 s = iwl4965_get_sub_band(priv, channel);
957 if (s >= EEPROM_TX_POWER_BANDS) { 959 if (s >= EEPROM_TX_POWER_BANDS) {
958 IWL_ERROR("Tx Power can not find channel %d\n", channel); 960 IWL_ERR(priv, "Tx Power can not find channel %d\n", channel);
959 return -1; 961 return -1;
960 } 962 }
961 963
@@ -1319,7 +1321,7 @@ static int iwl4965_fill_txpower_tbl(struct iwl_priv *priv, u8 band, u16 channel,
1319 * and 2) mimo txpower balance between Tx chains. */ 1321 * and 2) mimo txpower balance between Tx chains. */
1320 txatten_grp = iwl4965_get_tx_atten_grp(channel); 1322 txatten_grp = iwl4965_get_tx_atten_grp(channel);
1321 if (txatten_grp < 0) { 1323 if (txatten_grp < 0) {
1322 IWL_ERROR("Can't find txatten group for channel %d.\n", 1324 IWL_ERR(priv, "Can't find txatten group for channel %d.\n",
1323 channel); 1325 channel);
1324 return -EINVAL; 1326 return -EINVAL;
1325 } 1327 }
@@ -1727,7 +1729,7 @@ static int iwl4965_hw_get_temperature(const struct iwl_priv *priv)
1727 IWL_DEBUG_TEMP("Calib values R[1-3]: %d %d %d R4: %d\n", R1, R2, R3, vt); 1729 IWL_DEBUG_TEMP("Calib values R[1-3]: %d %d %d R4: %d\n", R1, R2, R3, vt);
1728 1730
1729 if (R3 == R1) { 1731 if (R3 == R1) {
1730 IWL_ERROR("Calibration conflict R1 == R3\n"); 1732 IWL_ERR(priv, "Calibration conflict R1 == R3\n");
1731 return -1; 1733 return -1;
1732 } 1734 }
1733 1735
@@ -2071,10 +2073,10 @@ static int iwl4965_tx_status_reply_tx(struct iwl_priv *priv,
2071 2073
2072 sc = le16_to_cpu(hdr->seq_ctrl); 2074 sc = le16_to_cpu(hdr->seq_ctrl);
2073 if (idx != (SEQ_TO_SN(sc) & 0xff)) { 2075 if (idx != (SEQ_TO_SN(sc) & 0xff)) {
2074 IWL_ERROR("BUG_ON idx doesn't match seq control" 2076 IWL_ERR(priv,
2075 " idx=%d, seq_idx=%d, seq=%d\n", 2077 "BUG_ON idx doesn't match seq control"
2076 idx, SEQ_TO_SN(sc), 2078 " idx=%d, seq_idx=%d, seq=%d\n",
2077 hdr->seq_ctrl); 2079 idx, SEQ_TO_SN(sc), hdr->seq_ctrl);
2078 return -1; 2080 return -1;
2079 } 2081 }
2080 2082
@@ -2133,7 +2135,7 @@ static void iwl4965_rx_reply_tx(struct iwl_priv *priv,
2133 u8 *qc = NULL; 2135 u8 *qc = NULL;
2134 2136
2135 if ((index >= txq->q.n_bd) || (iwl_queue_used(&txq->q, index) == 0)) { 2137 if ((index >= txq->q.n_bd) || (iwl_queue_used(&txq->q, index) == 0)) {
2136 IWL_ERROR("Read index for DMA queue txq_id (%d) index %d " 2138 IWL_ERR(priv, "Read index for DMA queue txq_id (%d) index %d "
2137 "is out of range [0-%d] %d %d\n", txq_id, 2139 "is out of range [0-%d] %d %d\n", txq_id,
2138 index, txq->q.n_bd, txq->q.write_ptr, 2140 index, txq->q.n_bd, txq->q.write_ptr,
2139 txq->q.read_ptr); 2141 txq->q.read_ptr);
@@ -2151,7 +2153,7 @@ static void iwl4965_rx_reply_tx(struct iwl_priv *priv,
2151 2153
2152 sta_id = iwl_get_ra_sta_id(priv, hdr); 2154 sta_id = iwl_get_ra_sta_id(priv, hdr);
2153 if (txq->sched_retry && unlikely(sta_id == IWL_INVALID_STATION)) { 2155 if (txq->sched_retry && unlikely(sta_id == IWL_INVALID_STATION)) {
2154 IWL_ERROR("Station not known\n"); 2156 IWL_ERR(priv, "Station not known\n");
2155 return; 2157 return;
2156 } 2158 }
2157 2159
@@ -2214,7 +2216,7 @@ static void iwl4965_rx_reply_tx(struct iwl_priv *priv,
2214 iwl_txq_check_empty(priv, sta_id, tid, txq_id); 2216 iwl_txq_check_empty(priv, sta_id, tid, txq_id);
2215 2217
2216 if (iwl_check_bits(status, TX_ABORT_REQUIRED_MSK)) 2218 if (iwl_check_bits(status, TX_ABORT_REQUIRED_MSK))
2217 IWL_ERROR("TODO: Implement Tx ABORT REQUIRED!!!\n"); 2219 IWL_ERR(priv, "TODO: Implement Tx ABORT REQUIRED!!!\n");
2218} 2220}
2219 2221
2220static int iwl4965_calc_rssi(struct iwl_priv *priv, 2222static int iwl4965_calc_rssi(struct iwl_priv *priv,