b43: Fix ofdmtab write regression

commit f04b3787bbce4567e28069a9ec97dcd804626ac7 introduced
a regression for the ofdmtable writing.

It incorrectly removed the writing of the high 16bits for
a 32bit table write and initialized the direction identifier
too late.

This patch does also some cleanups to make the code much more
readable and adds a few comments, so non rocket scientists are
also able to understand what this address caching is all about.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

1 files changed, 6 insertions, 6 deletions

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 064cbe11888..d7ea671394a 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -2264,12 +2264,6 @@ static int b43_chip_init(struct b43_wldev *dev)
         b43_write16(dev, B43_MMIO_POWERUP_DELAY,
                     dev->dev->bus->chipco.fast_pwrup_delay);
 
-        /* OFDM address caching. */
-        phy->ofdm_valid = 0;
-
-        /* PHY TX errors counter. */
-        atomic_set(&phy->txerr_cnt, B43_PHY_TX_BADNESS_LIMIT);
-
         err = 0;
         b43dbg(dev->wl, "Chip initialized\n");
 out:
@@ -3195,6 +3189,12 @@ static void setup_struct_phy_for_init(struct b43_wldev *dev,
         phy->channel = 0xFF;
 
         phy->hardware_power_control = !!modparam_hwpctl;
+
+        /* PHY TX errors counter. */
+        atomic_set(&phy->txerr_cnt, B43_PHY_TX_BADNESS_LIMIT);
+
+        /* OFDM-table address caching. */
+        phy->ofdmtab_addr_direction = B43_OFDMTAB_DIRECTION_UNKNOWN;
 }
 
 static void setup_struct_wldev_for_init(struct b43_wldev *dev)