diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-10-29 05:46:16 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:03:40 -0500 |
commit | 28fc1f5a0c375cb6375fa48e9a8b393f2a189be6 (patch) | |
tree | 95b3b517b02dd46ff0fc2728c1e70de8d6f78ed3 /drivers/net/wan/sdla.c | |
parent | 1b36efe07f83ecf50eddd431d067c7bf86318e87 (diff) |
[netdrvr] irq handler minor cleanups in several drivers
* use irq_handler_t where appropriate
* no need to use 'irq' function arg, its already stored in a data struct
* rename irq handler 'irq' argument to 'dummy', where the function
has been analyzed and proven not to use its first argument.
* remove always-false "dev_id == NULL" test from irq handlers
* remove pointless casts from void*
* declance: irq argument is not const
* add KERN_xxx printk prefix
* fix minor whitespace weirdness
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net/wan/sdla.c')
-rw-r--r-- | drivers/net/wan/sdla.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/wan/sdla.c b/drivers/net/wan/sdla.c index 05df0a345b6..73e2f278093 100644 --- a/drivers/net/wan/sdla.c +++ b/drivers/net/wan/sdla.c | |||
@@ -867,7 +867,7 @@ static void sdla_receive(struct net_device *dev) | |||
867 | spin_unlock_irqrestore(&sdla_lock, flags); | 867 | spin_unlock_irqrestore(&sdla_lock, flags); |
868 | } | 868 | } |
869 | 869 | ||
870 | static irqreturn_t sdla_isr(int irq, void *dev_id) | 870 | static irqreturn_t sdla_isr(int dummy, void *dev_id) |
871 | { | 871 | { |
872 | struct net_device *dev; | 872 | struct net_device *dev; |
873 | struct frad_local *flp; | 873 | struct frad_local *flp; |
@@ -879,7 +879,8 @@ static irqreturn_t sdla_isr(int irq, void *dev_id) | |||
879 | 879 | ||
880 | if (!flp->initialized) | 880 | if (!flp->initialized) |
881 | { | 881 | { |
882 | printk(KERN_WARNING "%s: irq %d for uninitialized device.\n", dev->name, irq); | 882 | printk(KERN_WARNING "%s: irq %d for uninitialized device.\n", |
883 | dev->name, dev->irq); | ||
883 | return IRQ_NONE; | 884 | return IRQ_NONE; |
884 | } | 885 | } |
885 | 886 | ||