sfc: Fix reporting of PHY id

Shuffle bits of the OUI into the conventional written order.

Replace PHY id component macros with functions.

Zero-pad PHY id components in log messages.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 3 deletions

diff --git a/drivers/net/sfc/xfp_phy.c b/drivers/net/sfc/xfp_phy.c
index 5d1c7f80000..2df467d2806 100644
--- a/drivers/net/sfc/xfp_phy.c
+++ b/drivers/net/sfc/xfp_phy.c
@@ -88,9 +88,9 @@ static int xfp_phy_init(struct efx_nic *efx)
                 return -ENOMEM;
         efx->phy_data = phy_data;
 
-        EFX_INFO(efx, "PHY ID reg %x (OUI %x model %x revision %x)\n",
-                 devid, MDIO_ID_OUI(devid), MDIO_ID_MODEL(devid),
-                 MDIO_ID_REV(devid));
+        EFX_INFO(efx, "PHY ID reg %x (OUI %06x model %02x revision %x)\n",
+                 devid, mdio_id_oui(devid), mdio_id_model(devid),
+                 mdio_id_rev(devid));
 
         phy_data->phy_mode = efx->phy_mode;