aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/igb
diff options
context:
space:
mode:
authorAlexander Duyck <alexander.h.duyck@intel.com>2009-10-27 11:49:49 -0400
committerDavid S. Miller <davem@davemloft.net>2009-10-28 04:20:17 -0400
commit094919a4b0c56d6afbfb5ea14567fbb2f8d47554 (patch)
treeaa58e687d3e918b097b1aeaca9467e66d957ad65 /drivers/net/igb
parent047e0030f1e601233ae5b03910602ec93c620bce (diff)
igb: remove rx checksum good counter
Counting packets with a good checksum can cause a significant amount of cache line bouncing due to the shared counter being written to by all of the queues. In order to avoid this I am removing the counter since we still have the checksum failed counter which will tell us if there are any issues. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/igb')
-rw-r--r--drivers/net/igb/igb.h1
-rw-r--r--drivers/net/igb/igb_ethtool.c1
-rw-r--r--drivers/net/igb/igb_main.c1
3 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/igb/igb.h b/drivers/net/igb/igb.h
index 86492c8957e..d27dcd1289c 100644
--- a/drivers/net/igb/igb.h
+++ b/drivers/net/igb/igb.h
@@ -254,7 +254,6 @@ struct igb_adapter {
254 int num_rx_queues; 254 int num_rx_queues;
255 255
256 u64 hw_csum_err; 256 u64 hw_csum_err;
257 u64 hw_csum_good;
258 u32 alloc_rx_buff_failed; 257 u32 alloc_rx_buff_failed;
259 u32 gorc; 258 u32 gorc;
260 u64 gorc_old; 259 u64 gorc_old;
diff --git a/drivers/net/igb/igb_ethtool.c b/drivers/net/igb/igb_ethtool.c
index f71276fec3f..2929546115c 100644
--- a/drivers/net/igb/igb_ethtool.c
+++ b/drivers/net/igb/igb_ethtool.c
@@ -95,7 +95,6 @@ static const struct igb_stats igb_gstrings_stats[] = {
95 { "tx_flow_control_xon", IGB_STAT(stats.xontxc) }, 95 { "tx_flow_control_xon", IGB_STAT(stats.xontxc) },
96 { "tx_flow_control_xoff", IGB_STAT(stats.xofftxc) }, 96 { "tx_flow_control_xoff", IGB_STAT(stats.xofftxc) },
97 { "rx_long_byte_count", IGB_STAT(stats.gorc) }, 97 { "rx_long_byte_count", IGB_STAT(stats.gorc) },
98 { "rx_csum_offload_good", IGB_STAT(hw_csum_good) },
99 { "rx_csum_offload_errors", IGB_STAT(hw_csum_err) }, 98 { "rx_csum_offload_errors", IGB_STAT(hw_csum_err) },
100 { "tx_dma_out_of_sync", IGB_STAT(stats.doosync) }, 99 { "tx_dma_out_of_sync", IGB_STAT(stats.doosync) },
101 { "alloc_rx_buff_failed", IGB_STAT(alloc_rx_buff_failed) }, 100 { "alloc_rx_buff_failed", IGB_STAT(alloc_rx_buff_failed) },
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index c15eb4c3916..e1d1c0c984b 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -4827,7 +4827,6 @@ static inline void igb_rx_checksum_adv(struct igb_adapter *adapter,
4827 skb->ip_summed = CHECKSUM_UNNECESSARY; 4827 skb->ip_summed = CHECKSUM_UNNECESSARY;
4828 4828
4829 dev_dbg(&adapter->pdev->dev, "cksum success: bits %08X\n", status_err); 4829 dev_dbg(&adapter->pdev->dev, "cksum success: bits %08X\n", status_err);
4830 adapter->hw_csum_good++;
4831} 4830}
4832 4831
4833static inline u16 igb_get_hlen(struct igb_adapter *adapter, 4832static inline u16 igb_get_hlen(struct igb_adapter *adapter,