diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-09-15 17:41:06 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 19:51:17 -0400 |
commit | 88d3aafdae5c5e1d2dd9489a5c8a24e29d335f2e (patch) | |
tree | 272ce75c30a170420ac8bbfd679c3faed9f9d20a /drivers/net/ibmveth.c | |
parent | 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0 (diff) |
[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls
For the operations
get-tx-csum
get-sg
get-tso
get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.
This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.
The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case. Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.
[ Resolved conflicts with set/get value ethtool patch... -DaveM ]
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ibmveth.c')
-rw-r--r-- | drivers/net/ibmveth.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index bdbf3dead4e..0636883449f 100644 --- a/drivers/net/ibmveth.c +++ b/drivers/net/ibmveth.c | |||
@@ -821,15 +821,11 @@ static const struct ethtool_ops netdev_ethtool_ops = { | |||
821 | .get_drvinfo = netdev_get_drvinfo, | 821 | .get_drvinfo = netdev_get_drvinfo, |
822 | .get_settings = netdev_get_settings, | 822 | .get_settings = netdev_get_settings, |
823 | .get_link = netdev_get_link, | 823 | .get_link = netdev_get_link, |
824 | .get_sg = ethtool_op_get_sg, | ||
825 | .get_tx_csum = ethtool_op_get_tx_csum, | ||
826 | .set_tx_csum = ibmveth_set_tx_csum, | 824 | .set_tx_csum = ibmveth_set_tx_csum, |
827 | .get_rx_csum = ibmveth_get_rx_csum, | 825 | .get_rx_csum = ibmveth_get_rx_csum, |
828 | .set_rx_csum = ibmveth_set_rx_csum, | 826 | .set_rx_csum = ibmveth_set_rx_csum, |
829 | .get_tso = ethtool_op_get_tso, | ||
830 | .get_ufo = ethtool_op_get_ufo, | ||
831 | .get_strings = ibmveth_get_strings, | 827 | .get_strings = ibmveth_get_strings, |
832 | .get_stats_count = ibmveth_get_stats_count, | 828 | .get_stats_count = ibmveth_get_stats_count, |
833 | .get_ethtool_stats = ibmveth_get_ethtool_stats, | 829 | .get_ethtool_stats = ibmveth_get_ethtool_stats, |
834 | }; | 830 | }; |
835 | 831 | ||