diff options
author | Andy Gospodarek <andy@greyhouse.net> | 2008-02-01 11:21:44 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-02-03 07:28:08 -0500 |
commit | 9b71c5e070946767ac8b19317df89700e967992a (patch) | |
tree | 443126f566719aa1dcebd66223c7030c228deb4f /drivers/net/e1000e | |
parent | 0a0863af0d41e2eea1391e4e5f375a47c5019ab7 (diff) |
e1000e: tweak irq allocation messages
There's too much noise on systems that don't support MSI. Let's get rid
of a few and make the real error message more specific.
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/e1000e')
-rw-r--r-- | drivers/net/e1000e/netdev.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 0a2cb7960c9..f58f017ee47 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e/netdev.c | |||
@@ -945,11 +945,7 @@ static int e1000_request_irq(struct e1000_adapter *adapter) | |||
945 | int irq_flags = IRQF_SHARED; | 945 | int irq_flags = IRQF_SHARED; |
946 | int err; | 946 | int err; |
947 | 947 | ||
948 | err = pci_enable_msi(adapter->pdev); | 948 | if (!pci_enable_msi(adapter->pdev)) { |
949 | if (err) { | ||
950 | ndev_warn(netdev, | ||
951 | "Unable to allocate MSI interrupt Error: %d\n", err); | ||
952 | } else { | ||
953 | adapter->flags |= FLAG_MSI_ENABLED; | 949 | adapter->flags |= FLAG_MSI_ENABLED; |
954 | handler = e1000_intr_msi; | 950 | handler = e1000_intr_msi; |
955 | irq_flags = 0; | 951 | irq_flags = 0; |
@@ -958,10 +954,12 @@ static int e1000_request_irq(struct e1000_adapter *adapter) | |||
958 | err = request_irq(adapter->pdev->irq, handler, irq_flags, netdev->name, | 954 | err = request_irq(adapter->pdev->irq, handler, irq_flags, netdev->name, |
959 | netdev); | 955 | netdev); |
960 | if (err) { | 956 | if (err) { |
957 | ndev_err(netdev, | ||
958 | "Unable to allocate %s interrupt (return: %d)\n", | ||
959 | adapter->flags & FLAG_MSI_ENABLED ? "MSI":"INTx", | ||
960 | err); | ||
961 | if (adapter->flags & FLAG_MSI_ENABLED) | 961 | if (adapter->flags & FLAG_MSI_ENABLED) |
962 | pci_disable_msi(adapter->pdev); | 962 | pci_disable_msi(adapter->pdev); |
963 | ndev_err(netdev, | ||
964 | "Unable to allocate interrupt Error: %d\n", err); | ||
965 | } | 963 | } |
966 | 964 | ||
967 | return err; | 965 | return err; |