diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2009-10-01 07:58:24 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-10-05 03:10:10 -0400 |
commit | 15f0a394c6573f4cb65a13095288ab9b9f8135f9 (patch) | |
tree | 211fe96826513a68a107feb9850817b9c4b2c8d1 /drivers/net/benet | |
parent | 1ddee09ff0420090d5b03ef3f9eba0e4db647035 (diff) |
net: Convert ethtool {get_stats, self_test}_count() ops to get_sset_count()
These string query operations were supposed to be replaced by the
generic get_sset_count() starting in 2007. Convert the remaining
implementations.
Also remove calls to these operations to initialise drvinfo->n_stats.
The ethtool core code already does that.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/benet')
-rw-r--r-- | drivers/net/benet/be_ethtool.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c index 11445df3dbc..851543a040c 100644 --- a/drivers/net/benet/be_ethtool.c +++ b/drivers/net/benet/be_ethtool.c | |||
@@ -281,9 +281,14 @@ be_get_stat_strings(struct net_device *netdev, uint32_t stringset, | |||
281 | } | 281 | } |
282 | } | 282 | } |
283 | 283 | ||
284 | static int be_get_stats_count(struct net_device *netdev) | 284 | static int be_get_sset_count(struct net_device *netdev, int stringset) |
285 | { | 285 | { |
286 | return ETHTOOL_STATS_NUM; | 286 | switch (stringset) { |
287 | case ETH_SS_STATS: | ||
288 | return ETHTOOL_STATS_NUM; | ||
289 | default: | ||
290 | return -EINVAL; | ||
291 | } | ||
287 | } | 292 | } |
288 | 293 | ||
289 | static int be_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd) | 294 | static int be_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd) |
@@ -364,7 +369,7 @@ const struct ethtool_ops be_ethtool_ops = { | |||
364 | .get_tso = ethtool_op_get_tso, | 369 | .get_tso = ethtool_op_get_tso, |
365 | .set_tso = ethtool_op_set_tso, | 370 | .set_tso = ethtool_op_set_tso, |
366 | .get_strings = be_get_stat_strings, | 371 | .get_strings = be_get_stat_strings, |
367 | .get_stats_count = be_get_stats_count, | 372 | .get_sset_count = be_get_sset_count, |
368 | .get_ethtool_stats = be_get_ethtool_stats, | 373 | .get_ethtool_stats = be_get_ethtool_stats, |
369 | .flash_device = be_do_flash, | 374 | .flash_device = be_do_flash, |
370 | }; | 375 | }; |