diff options
author | Hans Verkuil <hverkuil@xs4all.nl> | 2010-12-29 12:29:55 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-12-30 05:02:29 -0500 |
commit | 657f2271050beabe725ba101c1d840f51a41f33d (patch) | |
tree | 740e898564868e8900ed3b61fc6d57b44e114b57 /drivers/media/video/saa7134 | |
parent | 3ea2b673a55cee528f83653e711d09425ed4d8b6 (diff) |
[media] v4l: fix handling of v4l2_input.capabilities
The v4l core sets the v4l2_input.capabilities field based on the supplied
v4l2_ioctl_ops. However, several drivers do a memset or memcpy of the v4l2_input
struct, thus overwriting that field incorrectly.
Either remove the memset (which is already done by the v4l core), or add the
proper capabilities field in case of a memcpy.
The same is also true for v4l2_output, but that only affected the ivtv driver.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/saa7134')
-rw-r--r-- | drivers/media/video/saa7134/saa7134-video.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c index ee4ea5f001a..776ba2dd7f9 100644 --- a/drivers/media/video/saa7134/saa7134-video.c +++ b/drivers/media/video/saa7134/saa7134-video.c | |||
@@ -1748,7 +1748,6 @@ static int saa7134_enum_input(struct file *file, void *priv, | |||
1748 | return -EINVAL; | 1748 | return -EINVAL; |
1749 | if (NULL == card_in(dev, i->index).name) | 1749 | if (NULL == card_in(dev, i->index).name) |
1750 | return -EINVAL; | 1750 | return -EINVAL; |
1751 | memset(i, 0, sizeof(*i)); | ||
1752 | i->index = n; | 1751 | i->index = n; |
1753 | i->type = V4L2_INPUT_TYPE_CAMERA; | 1752 | i->type = V4L2_INPUT_TYPE_CAMERA; |
1754 | strcpy(i->name, card_in(dev, n).name); | 1753 | strcpy(i->name, card_in(dev, n).name); |