V4L/DVB (4646): Misc. changes, DiB3000MC, MT2060

Changed the attach-function of the dib3000mc-driver to return only one
frontend. In case of multiple dib3000-chips on one board, one has to call the
i2c-enumeration manually before.
Added a field to Microtune 2060 config to output the clock to other
tuners/device on a board.

Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

4 files changed, 66 insertions, 98 deletions

diff --git a/drivers/media/dvb/frontends/dib3000mc.c b/drivers/media/dvb/frontends/dib3000mc.c
index cc28417fa33..d7c4a98da12 100644
--- a/drivers/media/dvb/frontends/dib3000mc.c
+++ b/drivers/media/dvb/frontends/dib3000mc.c
@@ -584,56 +584,6 @@ static int dib3000mc_tune(struct dvb_frontend *demod, struct dibx000_ofdm_channe
         return 0;
 }
 
-static int dib3000mc_demod_output_mode(struct dvb_frontend *demod, int mode)
-{
-        struct dib3000mc_state *state = demod->demodulator_priv;
-        return dib3000mc_set_output_mode(state, mode);
-}
-
-static int dib3000mc_i2c_enumeration(struct dvb_frontend *demod[], int no_of_demods, u8 default_addr)
-{
-        struct dib3000mc_state *st;
-        int k,ret=0;
-        u8 new_addr;
-
-        static u8 DIB3000MC_I2C_ADDRESS[] = {20,22,24,26};
-
-        for (k = no_of_demods-1; k >= 0; k--) {
-                st = demod[k]->demodulator_priv;
-
-                /* designated i2c address */
-                new_addr          = DIB3000MC_I2C_ADDRESS[k];
-
-                st->i2c_addr = new_addr;
-                if (dib3000mc_identify(st) != 0) {
-                        st->i2c_addr = default_addr;
-                        if (dib3000mc_identify(st) != 0) {
-                                dprintk("-E-  DiB3000P/MC #%d: not identified\n", k);
-                                return -EINVAL;
-                        }
-                }
-
-                /* turn on div_out */
-                dib3000mc_demod_output_mode(demod[k], OUTMODE_MPEG2_PAR_CONT_CLK);
-
-                // set new i2c address and force divstr (Bit 1) to value 0 (Bit 0)
-                ret |= dib3000mc_write_word(st, 1024, (new_addr << 3) | 0x1);
-                st->i2c_addr = new_addr;
-        }
-
-        for (k = 0; k < no_of_demods; k++) {
-                st = demod[k]->demodulator_priv;
-
-                ret |= dib3000mc_write_word(st, 1024, st->i2c_addr << 3);
-
-                /* turn off data output */
-                dib3000mc_demod_output_mode(demod[k],OUTMODE_HIGH_Z);
-                dib3000mc_write_word(st, 769, (1 << 7) );
-
-        }
-        return 0;
-}
-
 struct i2c_adapter * dib3000mc_get_tuner_i2c_master(struct dvb_frontend *demod, int gating)
 {
         struct dib3000mc_state *st = demod->demodulator_priv;
@@ -826,61 +776,76 @@ void dib3000mc_set_config(struct dvb_frontend *fe, struct dib3000mc_config *cfg)
 }
 EXPORT_SYMBOL(dib3000mc_set_config);
 
-static struct dvb_frontend_ops dib3000mc_ops;
-
-int dib3000mc_attach(struct i2c_adapter *i2c_adap, int no_of_demods, u8 default_addr,                           u8 do_i2c_enum, struct dib3000mc_config cfg[], struct dvb_frontend *demod[])
+int dib3000mc_i2c_enumeration(struct i2c_adapter *i2c, int no_of_demods, u8 default_addr, struct dib3000mc_config cfg[])
 {
-        struct dib3000mc_state *st;
-        int k, num=0;
-
-        if (no_of_demods < 1)
-                return -EINVAL;
+        struct dib3000mc_state st = { .i2c_adap = i2c };
+        int k;
+        u8 new_addr;
 
-        for (k = 0; k < no_of_demods; k++) {
-                st = kzalloc(sizeof(struct dib3000mc_state), GFP_KERNEL);
-                if (st == NULL)
-                        goto error;
+        static u8 DIB3000MC_I2C_ADDRESS[] = {20,22,24,26};
 
-                num++;
+        for (k = no_of_demods-1; k >= 0; k--) {
+                st.cfg = &cfg[k];
 
-                st->cfg = &cfg[k];
-        //      st->gpio_val = cfg[k].gpio_val;
-        //      st->gpio_dir = cfg[k].gpio_dir;
-                st->i2c_adap = i2c_adap;
+                /* designated i2c address */
+                new_addr          = DIB3000MC_I2C_ADDRESS[k];
+                st.i2c_addr = new_addr;
+                if (dib3000mc_identify(&st) != 0) {
+                        st.i2c_addr = default_addr;
+                        if (dib3000mc_identify(&st) != 0) {
+                                dprintk("-E-  DiB3000P/MC #%d: not identified\n", k);
+                                return -ENODEV;
+                        }
+                }
 
-                demod[k]           = &st->demod;
-                demod[k]->demodulator_priv     = st;
-                memcpy(&st->demod.ops, &dib3000mc_ops, sizeof(struct dvb_frontend_ops));
+                dib3000mc_set_output_mode(&st, OUTMODE_MPEG2_PAR_CONT_CLK);
 
-//              INIT_COMPONENT_REGISTER_ACCESS(&st->register_access, 12, 16, dib7000p_register_read, dib7000p_register_write, st);
-//              demod[k]->register_access = &st->register_access;
+                // set new i2c address and force divstr (Bit 1) to value 0 (Bit 0)
+                dib3000mc_write_word(&st, 1024, (new_addr << 3) | 0x1);
+                st.i2c_addr = new_addr;
         }
 
-        if (do_i2c_enum) {
-                if (dib3000mc_i2c_enumeration(demod,no_of_demods,default_addr) != 0)
-                        goto error;
-        } else {
-                st = demod[0]->demodulator_priv;
-                st->i2c_addr = default_addr;
-                if (dib3000mc_identify(st) != 0)
-                        goto error;
-        }
+        for (k = 0; k < no_of_demods; k++) {
+                st.cfg = &cfg[k];
+                st.i2c_addr = DIB3000MC_I2C_ADDRESS[k];
 
-        for (k = 0; k < num; k++) {
-                st = demod[k]->demodulator_priv;
-                dibx000_init_i2c_master(&st->i2c_master, DIB3000MC, st->i2c_adap, st->i2c_addr);
-        }
+                dib3000mc_write_word(&st, 1024, st.i2c_addr << 3);
 
+                /* turn off data output */
+                dib3000mc_set_output_mode(&st, OUTMODE_HIGH_Z);
+        }
         return 0;
+}
+EXPORT_SYMBOL(dib3000mc_i2c_enumeration);
+
+static struct dvb_frontend_ops dib3000mc_ops;
+
+struct dvb_frontend * dib3000mc_attach(struct i2c_adapter *i2c_adap, u8 i2c_addr, struct dib3000mc_config *cfg)
+{
+        struct dvb_frontend *demod;
+        struct dib3000mc_state *st;
+        st = kzalloc(sizeof(struct dib3000mc_state), GFP_KERNEL);
+        if (st == NULL)
+                return NULL;
+
+        st->cfg = cfg;
+        st->i2c_adap = i2c_adap;
+
+        demod                   = &st->demod;
+        demod->demodulator_priv = st;
+        memcpy(&st->demod.ops, &dib3000mc_ops, sizeof(struct dvb_frontend_ops));
+
+        if (dib3000mc_identify(st) != 0)
+                goto error;
+
+        dibx000_init_i2c_master(&st->i2c_master, DIB3000MC, st->i2c_adap, st->i2c_addr);
+
+        return demod;
 
 error:
-        for (k = 0; k < num; k++) {
-                kfree(demod[k]->demodulator_priv);
-                demod[k] = NULL;
-        }
-        return -EINVAL;
+        kfree(st);
+        return NULL;
 }
-
 EXPORT_SYMBOL(dib3000mc_attach);
 
 static struct dvb_frontend_ops dib3000mc_ops = {
diff --git a/drivers/media/dvb/frontends/dib3000mc.h b/drivers/media/dvb/frontends/dib3000mc.h
index fd0b2e75599..b198cd5b184 100644
--- a/drivers/media/dvb/frontends/dib3000mc.h
+++ b/drivers/media/dvb/frontends/dib3000mc.h
@@ -37,17 +37,17 @@ struct dib3000mc_config {
 #define DEFAULT_DIB3000P_I2C_ADDRESS  24
 
 #if defined(CONFIG_DVB_DIB3000MC) || defined(CONFIG_DVB_DIB3000MC_MODULE)
-extern int dib3000mc_attach(struct i2c_adapter *i2c_adap, int no_of_demods, u8 default_addr,
-    u8 do_i2c_enum, struct dib3000mc_config cfg[], struct dvb_frontend *demod[]);
+extern struct dvb_frontend * dib3000mc_attach(struct i2c_adapter *i2c_adap, u8 i2c_addr, struct dib3000mc_config *cfg);
 #else
-static inline struct dvb_frontend* dib3000mc_attach(const struct dib3000_config* config,
-                                             struct i2c_adapter* i2c, struct dib_fe_xfer_ops *xfer_ops)
+static inline struct dvb_frontend * dib3000mc_attach(struct i2c_adapter *i2c_adap, u8 i2c_addr, struct dib3000mc_config *cfg)
 {
         printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __FUNCTION__);
         return NULL;
 }
 #endif // CONFIG_DVB_DIB3000MC
 
+extern int dib3000mc_i2c_enumeration(struct i2c_adapter *i2c, int no_of_demods, u8 default_addr, struct dib3000mc_config cfg[]);
+
 extern struct i2c_adapter * dib3000mc_get_tuner_i2c_master(struct dvb_frontend *demod, int gating);
 
 extern int dib3000mc_pid_control(struct dvb_frontend *fe, int index, int pid,int onoff);
diff --git a/drivers/media/dvb/frontends/mt2060.c b/drivers/media/dvb/frontends/mt2060.c
index 508ec1b6d1f..19bd66a1816 100644
--- a/drivers/media/dvb/frontends/mt2060.c
+++ b/drivers/media/dvb/frontends/mt2060.c
@@ -247,6 +247,9 @@ static void mt2060_calibrate(struct mt2060_priv *priv)
         if (mt2060_writeregs(priv,mt2060_config2,sizeof(mt2060_config2)))
                 return;
 
+        /* initialize the clock output */
+        mt2060_writereg(priv, REG_VGAG, (priv->cfg->clock_out << 6) | 0x30);
+
         do {
                 b |= (1 << 6); // FM1SS;
                 mt2060_writereg(priv, REG_LO2C1,b);
@@ -294,13 +297,13 @@ static int mt2060_get_bandwidth(struct dvb_frontend *fe, u32 *bandwidth)
 static int mt2060_init(struct dvb_frontend *fe)
 {
         struct mt2060_priv *priv = fe->tuner_priv;
-        return mt2060_writereg(priv, REG_VGAG,0x33);
+        return mt2060_writereg(priv, REG_VGAG, (priv->cfg->clock_out << 6) | 0x33);
 }
 
 static int mt2060_sleep(struct dvb_frontend *fe)
 {
         struct mt2060_priv *priv = fe->tuner_priv;
-        return mt2060_writereg(priv, REG_VGAG,0x30);
+        return mt2060_writereg(priv, REG_VGAG, (priv->cfg->clock_out << 6) | 0x30);
 }
 
 static int mt2060_release(struct dvb_frontend *fe)
diff --git a/drivers/media/dvb/frontends/mt2060.h b/drivers/media/dvb/frontends/mt2060.h
index c58b03e8234..471d3326e29 100644
--- a/drivers/media/dvb/frontends/mt2060.h
+++ b/drivers/media/dvb/frontends/mt2060.h
@@ -27,7 +27,7 @@ struct i2c_adapter;
 
 struct mt2060_config {
         u8 i2c_address;
-        /* Shall we add settings for the discrete outputs ? */
+        u8 clock_out; /* 0 = off, 1 = CLK/1, 2 = CLK/2, 3 = CLK/4 */
 };
 
 extern int mt2060_attach(struct dvb_frontend *fe, struct i2c_adapter *i2c, struct mt2060_config *cfg, u16 if1);