diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-03-13 19:27:46 -0400 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-04-29 18:00:29 -0400 |
commit | c94ccf9e3389ff55078a049bfe59b82f854436e8 (patch) | |
tree | 961616afc011b7d4a9f2cd2884d505e0c231560f /drivers/ieee1394/csr1212.c | |
parent | a1c6250cb60a52a7f799610f9a4b1f4e8671175f (diff) |
ieee1394: csr1212: warn on unreachable code
We want bugs to show themselves.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/ieee1394/csr1212.c')
-rw-r--r-- | drivers/ieee1394/csr1212.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/ieee1394/csr1212.c b/drivers/ieee1394/csr1212.c index 63bf11eb4d3..3c044fc5235 100644 --- a/drivers/ieee1394/csr1212.c +++ b/drivers/ieee1394/csr1212.c | |||
@@ -772,6 +772,7 @@ csr1212_generate_positions(struct csr1212_csr_rom_cache *cache, | |||
772 | 772 | ||
773 | default: | 773 | default: |
774 | /* Should never get here */ | 774 | /* Should never get here */ |
775 | WARN_ON(1); | ||
775 | break; | 776 | break; |
776 | } | 777 | } |
777 | 778 | ||
@@ -852,7 +853,8 @@ csr1212_generate_tree_subdir(struct csr1212_keyval *dir, u32 *data_buffer) | |||
852 | break; | 853 | break; |
853 | default: | 854 | default: |
854 | /* Should never get here */ | 855 | /* Should never get here */ |
855 | break; /* GDB breakpoint */ | 856 | WARN_ON(1); |
857 | break; | ||
856 | } | 858 | } |
857 | 859 | ||
858 | value |= (a->key.id & CSR1212_KV_KEY_ID_MASK) << | 860 | value |= (a->key.id & CSR1212_KV_KEY_ID_MASK) << |
@@ -889,7 +891,8 @@ static void csr1212_fill_cache(struct csr1212_csr_rom_cache *cache) | |||
889 | case CSR1212_KV_TYPE_IMMEDIATE: | 891 | case CSR1212_KV_TYPE_IMMEDIATE: |
890 | case CSR1212_KV_TYPE_CSR_OFFSET: | 892 | case CSR1212_KV_TYPE_CSR_OFFSET: |
891 | /* Should never get here */ | 893 | /* Should never get here */ |
892 | break; /* GDB breakpoint */ | 894 | WARN_ON(1); |
895 | break; | ||
893 | 896 | ||
894 | case CSR1212_KV_TYPE_LEAF: | 897 | case CSR1212_KV_TYPE_LEAF: |
895 | /* Don't copy over Extended ROM areas, they are | 898 | /* Don't copy over Extended ROM areas, they are |