aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/intel_display.c
diff options
context:
space:
mode:
authorZhenyu Wang <zhenyuw@linux.intel.com>2009-11-25 00:09:39 -0500
committerEric Anholt <eric@anholt.net>2010-01-12 18:07:34 -0500
commitb9241ea31fae4887104e5d1b3b18f4009c25a0c4 (patch)
treedbaea468aaf9d957ec2924ca6c7cc9501f963ca8 /drivers/gpu/drm/i915/intel_display.c
parent7c3f0a2726fed78e0e0afe3b6fc3c1f5b298e447 (diff)
drm/i915: Don't wait interruptible for possible plane buffer flush
When we setup buffer for display plane, we'll check any pending required GPU flush and possible make interruptible wait for flush complete. But that wait would be most possibly to fail in case of signals received for X process, which will then fail modeset process and put display engine in unconsistent state. The result could be blank screen or CPU hang, and DDX driver would always turn on outputs DPMS after whatever modeset fails or not. So this one creates new helper for setup display plane buffer, and when needing flush using uninterruptible wait for that. This one should fix bug like https://bugs.freedesktop.org/show_bug.cgi?id=24009. Also fixing mode switch stress test on Ironlake. Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> Signed-off-by: Eric Anholt <eric@anholt.net>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_display.c')
-rw-r--r--drivers/gpu/drm/i915/intel_display.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 42e8c031c2c..4b96a54b8e4 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1207,7 +1207,7 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
1207 return ret; 1207 return ret;
1208 } 1208 }
1209 1209
1210 ret = i915_gem_object_set_to_gtt_domain(obj, 1); 1210 ret = i915_gem_object_set_to_display_plane(obj);
1211 if (ret != 0) { 1211 if (ret != 0) {
1212 i915_gem_object_unpin(obj); 1212 i915_gem_object_unpin(obj);
1213 mutex_unlock(&dev->struct_mutex); 1213 mutex_unlock(&dev->struct_mutex);