diff options
author | Arjan van de Ven <arjan@linux.intel.com> | 2007-02-12 03:55:32 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-12 12:48:45 -0500 |
commit | 2b8693c0617e972fc0b2fd1ebf8de97e15b656c3 (patch) | |
tree | 3eb7dfbc8d5e4031e4992bdd566e211f5ada71f3 /drivers/char/mspec.c | |
parent | 5dfe4c964a0dd7bb3a1d64a4166835a153146207 (diff) |
[PATCH] mark struct file_operations const 3
Many struct file_operations in the kernel can be "const". Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data. In addition it'll catch accidental writes at compile time to
these shared resources.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/mspec.c')
-rw-r--r-- | drivers/char/mspec.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/char/mspec.c b/drivers/char/mspec.c index 235e8922611..7ac30612068 100644 --- a/drivers/char/mspec.c +++ b/drivers/char/mspec.c | |||
@@ -291,7 +291,7 @@ uncached_mmap(struct file *file, struct vm_area_struct *vma) | |||
291 | return mspec_mmap(file, vma, MSPEC_UNCACHED); | 291 | return mspec_mmap(file, vma, MSPEC_UNCACHED); |
292 | } | 292 | } |
293 | 293 | ||
294 | static struct file_operations fetchop_fops = { | 294 | static const struct file_operations fetchop_fops = { |
295 | .owner = THIS_MODULE, | 295 | .owner = THIS_MODULE, |
296 | .mmap = fetchop_mmap | 296 | .mmap = fetchop_mmap |
297 | }; | 297 | }; |
@@ -302,7 +302,7 @@ static struct miscdevice fetchop_miscdev = { | |||
302 | .fops = &fetchop_fops | 302 | .fops = &fetchop_fops |
303 | }; | 303 | }; |
304 | 304 | ||
305 | static struct file_operations cached_fops = { | 305 | static const struct file_operations cached_fops = { |
306 | .owner = THIS_MODULE, | 306 | .owner = THIS_MODULE, |
307 | .mmap = cached_mmap | 307 | .mmap = cached_mmap |
308 | }; | 308 | }; |
@@ -313,7 +313,7 @@ static struct miscdevice cached_miscdev = { | |||
313 | .fops = &cached_fops | 313 | .fops = &cached_fops |
314 | }; | 314 | }; |
315 | 315 | ||
316 | static struct file_operations uncached_fops = { | 316 | static const struct file_operations uncached_fops = { |
317 | .owner = THIS_MODULE, | 317 | .owner = THIS_MODULE, |
318 | .mmap = uncached_mmap | 318 | .mmap = uncached_mmap |
319 | }; | 319 | }; |