diff options
| author | Michael Buesch <mb@bu3sch.de> | 2009-09-22 19:43:36 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-09-23 10:39:28 -0400 |
| commit | e898893399335514b10dfbd75598f8308976abe4 (patch) | |
| tree | af829247f12aed6e9371dcee8ed119ce54a3e0c3 /drivers/block | |
| parent | c02e3f361c75da04ca3025b4d19e947e9cc62ed3 (diff) | |
dac960: fix undefined behavior on empty string
Fix undefined behavior due to a buffer underrun if an empty string is
written to the proc file.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/DAC960.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c index c77b6f3c28e..6fa7b0fdbdf 100644 --- a/drivers/block/DAC960.c +++ b/drivers/block/DAC960.c | |||
| @@ -6562,7 +6562,7 @@ static int DAC960_ProcWriteUserCommand(struct file *file, | |||
| 6562 | if (copy_from_user(CommandBuffer, Buffer, Count)) return -EFAULT; | 6562 | if (copy_from_user(CommandBuffer, Buffer, Count)) return -EFAULT; |
| 6563 | CommandBuffer[Count] = '\0'; | 6563 | CommandBuffer[Count] = '\0'; |
| 6564 | Length = strlen(CommandBuffer); | 6564 | Length = strlen(CommandBuffer); |
| 6565 | if (CommandBuffer[Length-1] == '\n') | 6565 | if (Length > 0 && CommandBuffer[Length-1] == '\n') |
| 6566 | CommandBuffer[--Length] = '\0'; | 6566 | CommandBuffer[--Length] = '\0'; |
| 6567 | if (Controller->FirmwareType == DAC960_V1_Controller) | 6567 | if (Controller->FirmwareType == DAC960_V1_Controller) |
| 6568 | return (DAC960_V1_ExecuteUserCommand(Controller, CommandBuffer) | 6568 | return (DAC960_V1_ExecuteUserCommand(Controller, CommandBuffer) |