[ATM]: [drivers] ioremap balanced with iounmap

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Signed-off-by: chas williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 9 insertions, 5 deletions

diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c
index 38b688f9f6a..737cea49f87 100644
--- a/drivers/atm/firestream.c
+++ b/drivers/atm/firestream.c
@@ -1710,7 +1710,7 @@ static int __devinit fs_init (struct fs_dev *dev)
                 /* This bit is documented as "RESERVED" */
                 if (isr & ISR_INIT_ERR) {
                         printk (KERN_ERR "Error initializing the FS... \n");
-                        return 1;
+                        goto unmap;
                 }
                 if (isr & ISR_INIT) {
                         fs_dprintk (FS_DEBUG_INIT, "Ha! Initialized OK!\n");
@@ -1723,7 +1723,7 @@ static int __devinit fs_init (struct fs_dev *dev)
 
         if (!to) {
                 printk (KERN_ERR "timeout initializing the FS... \n");
-                return 1;
+                goto unmap;
         }
 
         /* XXX fix for fs155 */
@@ -1803,7 +1803,7 @@ static int __devinit fs_init (struct fs_dev *dev)
         if (!dev->atm_vccs) {
                 printk (KERN_WARNING "Couldn't allocate memory for VCC buffers. Woops!\n");
                 /* XXX Clean up..... */
-                return 1;
+                goto unmap;
         }
 
         dev->tx_inuse = kzalloc (dev->nchannels / 8 /* bits/byte */ , GFP_KERNEL);
@@ -1813,7 +1813,7 @@ static int __devinit fs_init (struct fs_dev *dev)
         if (!dev->tx_inuse) {
                 printk (KERN_WARNING "Couldn't allocate memory for tx_inuse bits!\n");
                 /* XXX Clean up..... */
-                return 1;
+                goto unmap;
         }
         /* -- RAS1 : FS155 and 50 differ. Default (0) should be OK for both */
         /* -- RAS2 : FS50 only: Default is OK. */
@@ -1840,7 +1840,7 @@ static int __devinit fs_init (struct fs_dev *dev)
         if (request_irq (dev->irq, fs_irq, IRQF_SHARED, "firestream", dev)) {
                 printk (KERN_WARNING "couldn't get irq %d for firestream.\n", pci_dev->irq);
                 /* XXX undo all previous stuff... */
-                return 1;
+                goto unmap;
         }
         fs_dprintk (FS_DEBUG_INIT, "Grabbed irq %d for dev at %p.\n", dev->irq, dev);
   
@@ -1890,6 +1890,9 @@ static int __devinit fs_init (struct fs_dev *dev)
   
         func_exit ();
         return 0;
+unmap:
+        iounmap(dev->base);
+        return 1;
 }
 
 static int __devinit firestream_init_one (struct pci_dev *pci_dev,
@@ -2012,6 +2015,7 @@ static void __devexit firestream_remove_one (struct pci_dev *pdev)
                 for (i=0;i < FS_NR_RX_QUEUES;i++)
                         free_queue (dev, &dev->rx_rq[i]);
 
+                iounmap(dev->base);
                 fs_dprintk (FS_DEBUG_ALLOC, "Free fs-dev: %p\n", dev);
                 nxtdev = dev->next;
                 kfree (dev);