diff options
author | Julia Lawall <julia@diku.dk> | 2008-04-10 22:09:24 -0400 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2008-04-29 02:52:45 -0400 |
commit | 9030062f3d61f87c1e787b3aa134fa3a8e4b2d25 (patch) | |
tree | a24cd60df75180ac54a115842be631bd3f3ed003 /drivers/acpi/processor_core.c | |
parent | e9ae71078b2c8657c0e8de808b76b76049806906 (diff) |
ACPI: elide a non-zero test on a result that is never 0
thermal_cooling_device_register used to return NULL if THERMAL is "n".
As the ACPI fan, processor and video drivers SELECT the generic
thermal in PATCH 01, this is not a problem any more.
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/processor_core.c')
-rw-r--r-- | drivers/acpi/processor_core.c | 31 |
1 files changed, 15 insertions, 16 deletions
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c index a825b431b64..ea5f628dcc1 100644 --- a/drivers/acpi/processor_core.c +++ b/drivers/acpi/processor_core.c | |||
@@ -674,22 +674,21 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device) | |||
674 | result = PTR_ERR(pr->cdev); | 674 | result = PTR_ERR(pr->cdev); |
675 | goto end; | 675 | goto end; |
676 | } | 676 | } |
677 | if (pr->cdev) { | 677 | |
678 | printk(KERN_INFO PREFIX | 678 | printk(KERN_INFO PREFIX |
679 | "%s is registered as cooling_device%d\n", | 679 | "%s is registered as cooling_device%d\n", |
680 | device->dev.bus_id, pr->cdev->id); | 680 | device->dev.bus_id, pr->cdev->id); |
681 | 681 | ||
682 | result = sysfs_create_link(&device->dev.kobj, | 682 | result = sysfs_create_link(&device->dev.kobj, |
683 | &pr->cdev->device.kobj, | 683 | &pr->cdev->device.kobj, |
684 | "thermal_cooling"); | 684 | "thermal_cooling"); |
685 | if (result) | 685 | if (result) |
686 | return result; | 686 | printk(KERN_ERR PREFIX "Create sysfs link\n"); |
687 | result = sysfs_create_link(&pr->cdev->device.kobj, | 687 | result = sysfs_create_link(&pr->cdev->device.kobj, |
688 | &device->dev.kobj, | 688 | &device->dev.kobj, |
689 | "device"); | 689 | "device"); |
690 | if (result) | 690 | if (result) |
691 | return result; | 691 | printk(KERN_ERR PREFIX "Create sysfs link\n"); |
692 | } | ||
693 | 692 | ||
694 | if (pr->flags.throttling) { | 693 | if (pr->flags.throttling) { |
695 | printk(KERN_INFO PREFIX "%s [%s] (supports", | 694 | printk(KERN_INFO PREFIX "%s [%s] (supports", |