diff options
author | Bob Moore <robert.moore@intel.com> | 2009-12-11 02:23:22 -0500 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2009-12-15 17:29:36 -0500 |
commit | 3a58176e4fa47d8232e04131b023f3f2ecd7084b (patch) | |
tree | ee064fd4d8bcc7ba16926241262cec6b74caec03 /drivers/acpi/acpica/nsrepair.c | |
parent | ea7c5ec148044776d5e134e52a3e1aca8d662dbe (diff) |
ACPICA: Remove messages if predefined repair(s) are successful
Repair mechanism was considered too wordy. Now, messages are only
unconditionally emitted if the return object cannot be repaired.
Existing messages for successful repairs were converted to
ACPI_DEBUG_PRINT messages for now. ACPICA BZ 827.
http://www.acpica.org/bugzilla/show_bug.cgi?id=827
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/acpi/acpica/nsrepair.c')
-rw-r--r-- | drivers/acpi/acpica/nsrepair.c | 32 |
1 files changed, 18 insertions, 14 deletions
diff --git a/drivers/acpi/acpica/nsrepair.c b/drivers/acpi/acpica/nsrepair.c index 062a016d455..907f60c9c9e 100644 --- a/drivers/acpi/acpica/nsrepair.c +++ b/drivers/acpi/acpica/nsrepair.c | |||
@@ -118,6 +118,8 @@ acpi_ns_repair_object(struct acpi_predefined_data *data, | |||
118 | union acpi_operand_object *new_object; | 118 | union acpi_operand_object *new_object; |
119 | acpi_status status; | 119 | acpi_status status; |
120 | 120 | ||
121 | ACPI_FUNCTION_NAME(ns_repair_object); | ||
122 | |||
121 | /* | 123 | /* |
122 | * At this point, we know that the type of the returned object was not | 124 | * At this point, we know that the type of the returned object was not |
123 | * one of the expected types for this predefined name. Attempt to | 125 | * one of the expected types for this predefined name. Attempt to |
@@ -171,19 +173,18 @@ acpi_ns_repair_object(struct acpi_predefined_data *data, | |||
171 | return_object->common.reference_count--; | 173 | return_object->common.reference_count--; |
172 | } | 174 | } |
173 | 175 | ||
174 | ACPI_INFO_PREDEFINED((AE_INFO, data->pathname, data->node_flags, | 176 | ACPI_DEBUG_PRINT((ACPI_DB_REPAIR, |
175 | "Converted %s to expected %s at index %u", | 177 | "%s: Converted %s to expected %s at index %u\n", |
176 | acpi_ut_get_object_type_name | 178 | data->pathname, |
177 | (return_object), | 179 | acpi_ut_get_object_type_name(return_object), |
178 | acpi_ut_get_object_type_name(new_object), | 180 | acpi_ut_get_object_type_name(new_object), |
179 | package_index)); | 181 | package_index)); |
180 | } else { | 182 | } else { |
181 | ACPI_INFO_PREDEFINED((AE_INFO, data->pathname, data->node_flags, | 183 | ACPI_DEBUG_PRINT((ACPI_DB_REPAIR, |
182 | "Converted %s to expected %s", | 184 | "%s: Converted %s to expected %s\n", |
183 | acpi_ut_get_object_type_name | 185 | data->pathname, |
184 | (return_object), | 186 | acpi_ut_get_object_type_name(return_object), |
185 | acpi_ut_get_object_type_name | 187 | acpi_ut_get_object_type_name(new_object))); |
186 | (new_object))); | ||
187 | } | 188 | } |
188 | 189 | ||
189 | /* Delete old object, install the new return object */ | 190 | /* Delete old object, install the new return object */ |
@@ -528,6 +529,8 @@ acpi_ns_repair_package_list(struct acpi_predefined_data *data, | |||
528 | { | 529 | { |
529 | union acpi_operand_object *pkg_obj_desc; | 530 | union acpi_operand_object *pkg_obj_desc; |
530 | 531 | ||
532 | ACPI_FUNCTION_NAME(ns_repair_package_list); | ||
533 | |||
531 | /* | 534 | /* |
532 | * Create the new outer package and populate it. The new package will | 535 | * Create the new outer package and populate it. The new package will |
533 | * have a single element, the lone subpackage. | 536 | * have a single element, the lone subpackage. |
@@ -544,8 +547,9 @@ acpi_ns_repair_package_list(struct acpi_predefined_data *data, | |||
544 | *obj_desc_ptr = pkg_obj_desc; | 547 | *obj_desc_ptr = pkg_obj_desc; |
545 | data->flags |= ACPI_OBJECT_REPAIRED; | 548 | data->flags |= ACPI_OBJECT_REPAIRED; |
546 | 549 | ||
547 | ACPI_INFO_PREDEFINED((AE_INFO, data->pathname, data->node_flags, | 550 | ACPI_DEBUG_PRINT((ACPI_DB_REPAIR, |
548 | "Repaired Incorrectly formed Package")); | 551 | "%s: Repaired incorrectly formed Package\n", |
552 | data->pathname)); | ||
549 | 553 | ||
550 | return (AE_OK); | 554 | return (AE_OK); |
551 | } | 555 | } |