diff options
author | Joe Perches <joe@perches.com> | 2009-12-09 01:30:50 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-12-09 02:25:57 -0500 |
commit | f58e1f53de52a70391b6478617311207c7203363 (patch) | |
tree | 0e024e016a1060a2f17c4ae9d7dd910853e589ba /arch/x86/kernel/microcode_core.c | |
parent | 4c68db38c85188824b21698842b42a62b4f78657 (diff) |
arch/x86/kernel/microcode*: Use pr_fmt() and remove duplicated KERN_ERR prefix
- Use #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
- Remove "microcode: " prefix from each pr_<level>
- Fix duplicated KERN_ERR prefix
- Coalesce pr_<level> format strings
- Add a space after an exclamation point
No other change in output.
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Andreas Herrmann <herrmann.der.user@googlemail.com>
LKML-Reference: <1260340250.27677.191.camel@Joe-Laptop.home>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/microcode_core.c')
-rw-r--r-- | arch/x86/kernel/microcode_core.c | 26 |
1 files changed, 14 insertions, 12 deletions
diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c index e68aae39786..844c02c65fc 100644 --- a/arch/x86/kernel/microcode_core.c +++ b/arch/x86/kernel/microcode_core.c | |||
@@ -70,6 +70,9 @@ | |||
70 | * Fix sigmatch() macro to handle old CPUs with pf == 0. | 70 | * Fix sigmatch() macro to handle old CPUs with pf == 0. |
71 | * Thanks to Stuart Swales for pointing out this bug. | 71 | * Thanks to Stuart Swales for pointing out this bug. |
72 | */ | 72 | */ |
73 | |||
74 | #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt | ||
75 | |||
73 | #include <linux/platform_device.h> | 76 | #include <linux/platform_device.h> |
74 | #include <linux/miscdevice.h> | 77 | #include <linux/miscdevice.h> |
75 | #include <linux/capability.h> | 78 | #include <linux/capability.h> |
@@ -209,7 +212,7 @@ static ssize_t microcode_write(struct file *file, const char __user *buf, | |||
209 | ssize_t ret = -EINVAL; | 212 | ssize_t ret = -EINVAL; |
210 | 213 | ||
211 | if ((len >> PAGE_SHIFT) > totalram_pages) { | 214 | if ((len >> PAGE_SHIFT) > totalram_pages) { |
212 | pr_err("microcode: too much data (max %ld pages)\n", totalram_pages); | 215 | pr_err("too much data (max %ld pages)\n", totalram_pages); |
213 | return ret; | 216 | return ret; |
214 | } | 217 | } |
215 | 218 | ||
@@ -244,7 +247,7 @@ static int __init microcode_dev_init(void) | |||
244 | 247 | ||
245 | error = misc_register(µcode_dev); | 248 | error = misc_register(µcode_dev); |
246 | if (error) { | 249 | if (error) { |
247 | pr_err("microcode: can't misc_register on minor=%d\n", MICROCODE_MINOR); | 250 | pr_err("can't misc_register on minor=%d\n", MICROCODE_MINOR); |
248 | return error; | 251 | return error; |
249 | } | 252 | } |
250 | 253 | ||
@@ -359,7 +362,7 @@ static enum ucode_state microcode_resume_cpu(int cpu) | |||
359 | if (!uci->mc) | 362 | if (!uci->mc) |
360 | return UCODE_NFOUND; | 363 | return UCODE_NFOUND; |
361 | 364 | ||
362 | pr_debug("microcode: CPU%d updated upon resume\n", cpu); | 365 | pr_debug("CPU%d updated upon resume\n", cpu); |
363 | apply_microcode_on_target(cpu); | 366 | apply_microcode_on_target(cpu); |
364 | 367 | ||
365 | return UCODE_OK; | 368 | return UCODE_OK; |
@@ -379,7 +382,7 @@ static enum ucode_state microcode_init_cpu(int cpu) | |||
379 | ustate = microcode_ops->request_microcode_fw(cpu, µcode_pdev->dev); | 382 | ustate = microcode_ops->request_microcode_fw(cpu, µcode_pdev->dev); |
380 | 383 | ||
381 | if (ustate == UCODE_OK) { | 384 | if (ustate == UCODE_OK) { |
382 | pr_debug("microcode: CPU%d updated upon init\n", cpu); | 385 | pr_debug("CPU%d updated upon init\n", cpu); |
383 | apply_microcode_on_target(cpu); | 386 | apply_microcode_on_target(cpu); |
384 | } | 387 | } |
385 | 388 | ||
@@ -406,7 +409,7 @@ static int mc_sysdev_add(struct sys_device *sys_dev) | |||
406 | if (!cpu_online(cpu)) | 409 | if (!cpu_online(cpu)) |
407 | return 0; | 410 | return 0; |
408 | 411 | ||
409 | pr_debug("microcode: CPU%d added\n", cpu); | 412 | pr_debug("CPU%d added\n", cpu); |
410 | 413 | ||
411 | err = sysfs_create_group(&sys_dev->kobj, &mc_attr_group); | 414 | err = sysfs_create_group(&sys_dev->kobj, &mc_attr_group); |
412 | if (err) | 415 | if (err) |
@@ -425,7 +428,7 @@ static int mc_sysdev_remove(struct sys_device *sys_dev) | |||
425 | if (!cpu_online(cpu)) | 428 | if (!cpu_online(cpu)) |
426 | return 0; | 429 | return 0; |
427 | 430 | ||
428 | pr_debug("microcode: CPU%d removed\n", cpu); | 431 | pr_debug("CPU%d removed\n", cpu); |
429 | microcode_fini_cpu(cpu); | 432 | microcode_fini_cpu(cpu); |
430 | sysfs_remove_group(&sys_dev->kobj, &mc_attr_group); | 433 | sysfs_remove_group(&sys_dev->kobj, &mc_attr_group); |
431 | return 0; | 434 | return 0; |
@@ -473,15 +476,15 @@ mc_cpu_callback(struct notifier_block *nb, unsigned long action, void *hcpu) | |||
473 | microcode_update_cpu(cpu); | 476 | microcode_update_cpu(cpu); |
474 | case CPU_DOWN_FAILED: | 477 | case CPU_DOWN_FAILED: |
475 | case CPU_DOWN_FAILED_FROZEN: | 478 | case CPU_DOWN_FAILED_FROZEN: |
476 | pr_debug("microcode: CPU%d added\n", cpu); | 479 | pr_debug("CPU%d added\n", cpu); |
477 | if (sysfs_create_group(&sys_dev->kobj, &mc_attr_group)) | 480 | if (sysfs_create_group(&sys_dev->kobj, &mc_attr_group)) |
478 | pr_err("microcode: Failed to create group for CPU%d\n", cpu); | 481 | pr_err("Failed to create group for CPU%d\n", cpu); |
479 | break; | 482 | break; |
480 | case CPU_DOWN_PREPARE: | 483 | case CPU_DOWN_PREPARE: |
481 | case CPU_DOWN_PREPARE_FROZEN: | 484 | case CPU_DOWN_PREPARE_FROZEN: |
482 | /* Suspend is in progress, only remove the interface */ | 485 | /* Suspend is in progress, only remove the interface */ |
483 | sysfs_remove_group(&sys_dev->kobj, &mc_attr_group); | 486 | sysfs_remove_group(&sys_dev->kobj, &mc_attr_group); |
484 | pr_debug("microcode: CPU%d removed\n", cpu); | 487 | pr_debug("CPU%d removed\n", cpu); |
485 | break; | 488 | break; |
486 | case CPU_DEAD: | 489 | case CPU_DEAD: |
487 | case CPU_UP_CANCELED_FROZEN: | 490 | case CPU_UP_CANCELED_FROZEN: |
@@ -507,7 +510,7 @@ static int __init microcode_init(void) | |||
507 | microcode_ops = init_amd_microcode(); | 510 | microcode_ops = init_amd_microcode(); |
508 | 511 | ||
509 | if (!microcode_ops) { | 512 | if (!microcode_ops) { |
510 | pr_err("microcode: no support for this CPU vendor\n"); | 513 | pr_err("no support for this CPU vendor\n"); |
511 | return -ENODEV; | 514 | return -ENODEV; |
512 | } | 515 | } |
513 | 516 | ||
@@ -541,8 +544,7 @@ static int __init microcode_init(void) | |||
541 | register_hotcpu_notifier(&mc_cpu_notifier); | 544 | register_hotcpu_notifier(&mc_cpu_notifier); |
542 | 545 | ||
543 | pr_info("Microcode Update Driver: v" MICROCODE_VERSION | 546 | pr_info("Microcode Update Driver: v" MICROCODE_VERSION |
544 | " <tigran@aivazian.fsnet.co.uk>," | 547 | " <tigran@aivazian.fsnet.co.uk>, Peter Oruba\n"); |
545 | " Peter Oruba\n"); | ||
546 | 548 | ||
547 | return 0; | 549 | return 0; |
548 | } | 550 | } |