diff options
author | Alexander Graf <agraf@suse.de> | 2010-01-15 08:49:12 -0500 |
---|---|---|
committer | Marcelo Tosatti <mtosatti@redhat.com> | 2010-03-01 10:35:55 -0500 |
commit | 1c0006d8d131585095c4a27dbfcfb3970807a35e (patch) | |
tree | 2fe67697516624dd058efd90654fa59fcd9d112b /arch/powerpc/include/asm/kvm_ppc.h | |
parent | 180a34d2d3fda0151154f9cead4aab9dddd3d0c1 (diff) |
KVM: PPC: Fix initial GPR settings
Commit 7d01b4c3ed2bb33ceaf2d270cb4831a67a76b51b introduced PACA backed vcpu
values. With this patch, when a userspace app was setting GPRs before it was
actually first loaded, the set values get discarded.
This is because vcpu_load loads them from the vcpu backing store that we use
whenever we're not owning the PACA.
That behavior is not really a major problem, because we don't need it for
qemu. Other users (like kvmctl) do have problems with it though, so let's
better do it right.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'arch/powerpc/include/asm/kvm_ppc.h')
-rw-r--r-- | arch/powerpc/include/asm/kvm_ppc.h | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index 09816da9e95..e2642829e43 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h | |||
@@ -28,6 +28,9 @@ | |||
28 | #include <linux/types.h> | 28 | #include <linux/types.h> |
29 | #include <linux/kvm_types.h> | 29 | #include <linux/kvm_types.h> |
30 | #include <linux/kvm_host.h> | 30 | #include <linux/kvm_host.h> |
31 | #ifdef CONFIG_PPC_BOOK3S | ||
32 | #include <asm/kvm_book3s.h> | ||
33 | #endif | ||
31 | 34 | ||
32 | enum emulation_result { | 35 | enum emulation_result { |
33 | EMULATE_DONE, /* no further processing */ | 36 | EMULATE_DONE, /* no further processing */ |
@@ -102,9 +105,10 @@ extern void kvmppc_core_destroy_mmu(struct kvm_vcpu *vcpu); | |||
102 | 105 | ||
103 | static inline void kvmppc_set_gpr(struct kvm_vcpu *vcpu, int num, ulong val) | 106 | static inline void kvmppc_set_gpr(struct kvm_vcpu *vcpu, int num, ulong val) |
104 | { | 107 | { |
105 | if ( num < 14 ) | 108 | if ( num < 14 ) { |
106 | get_paca()->shadow_vcpu.gpr[num] = val; | 109 | get_paca()->shadow_vcpu.gpr[num] = val; |
107 | else | 110 | to_book3s(vcpu)->shadow_vcpu.gpr[num] = val; |
111 | } else | ||
108 | vcpu->arch.gpr[num] = val; | 112 | vcpu->arch.gpr[num] = val; |
109 | } | 113 | } |
110 | 114 | ||
@@ -119,6 +123,7 @@ static inline ulong kvmppc_get_gpr(struct kvm_vcpu *vcpu, int num) | |||
119 | static inline void kvmppc_set_cr(struct kvm_vcpu *vcpu, u32 val) | 123 | static inline void kvmppc_set_cr(struct kvm_vcpu *vcpu, u32 val) |
120 | { | 124 | { |
121 | get_paca()->shadow_vcpu.cr = val; | 125 | get_paca()->shadow_vcpu.cr = val; |
126 | to_book3s(vcpu)->shadow_vcpu.cr = val; | ||
122 | } | 127 | } |
123 | 128 | ||
124 | static inline u32 kvmppc_get_cr(struct kvm_vcpu *vcpu) | 129 | static inline u32 kvmppc_get_cr(struct kvm_vcpu *vcpu) |
@@ -129,6 +134,7 @@ static inline u32 kvmppc_get_cr(struct kvm_vcpu *vcpu) | |||
129 | static inline void kvmppc_set_xer(struct kvm_vcpu *vcpu, u32 val) | 134 | static inline void kvmppc_set_xer(struct kvm_vcpu *vcpu, u32 val) |
130 | { | 135 | { |
131 | get_paca()->shadow_vcpu.xer = val; | 136 | get_paca()->shadow_vcpu.xer = val; |
137 | to_book3s(vcpu)->shadow_vcpu.xer = val; | ||
132 | } | 138 | } |
133 | 139 | ||
134 | static inline u32 kvmppc_get_xer(struct kvm_vcpu *vcpu) | 140 | static inline u32 kvmppc_get_xer(struct kvm_vcpu *vcpu) |