diff options
author | Mike Frysinger <michael.frysinger@analog.com> | 2007-07-12 10:58:21 -0400 |
---|---|---|
committer | Bryan Wu <bryan.wu@analog.com> | 2007-07-12 10:58:21 -0400 |
commit | 1f83b8f148a1eb967d2a628cbb741cd56fb54572 (patch) | |
tree | 43b56238822ab35ec90a9ee9e9c014247950622f /arch/blackfin/mach-common | |
parent | 669b792c77bbc30e9f4d9c95dbc918dc348c49c2 (diff) |
Blackfin arch: cleanup warnings from checkpatch -- no functional changes
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com>
Signed-off-by: Bryan Wu <bryan.wu@analog.com>
Diffstat (limited to 'arch/blackfin/mach-common')
-rw-r--r-- | arch/blackfin/mach-common/cplbinfo.c | 13 | ||||
-rw-r--r-- | arch/blackfin/mach-common/entry.S | 2 | ||||
-rw-r--r-- | arch/blackfin/mach-common/ints-priority-dc.c | 8 | ||||
-rw-r--r-- | arch/blackfin/mach-common/ints-priority-sc.c | 10 | ||||
-rw-r--r-- | arch/blackfin/mach-common/pm.c | 4 |
5 files changed, 17 insertions, 20 deletions
diff --git a/arch/blackfin/mach-common/cplbinfo.c b/arch/blackfin/mach-common/cplbinfo.c index caa9623e6bd..785ca981697 100644 --- a/arch/blackfin/mach-common/cplbinfo.c +++ b/arch/blackfin/mach-common/cplbinfo.c | |||
@@ -31,11 +31,10 @@ | |||
31 | #include <linux/kernel.h> | 31 | #include <linux/kernel.h> |
32 | #include <linux/init.h> | 32 | #include <linux/init.h> |
33 | #include <linux/proc_fs.h> | 33 | #include <linux/proc_fs.h> |
34 | #include <linux/uaccess.h> | ||
34 | 35 | ||
35 | #include <asm/current.h> | 36 | #include <asm/current.h> |
36 | #include <asm/uaccess.h> | ||
37 | #include <asm/system.h> | 37 | #include <asm/system.h> |
38 | |||
39 | #include <asm/cplb.h> | 38 | #include <asm/cplb.h> |
40 | #include <asm/blackfin.h> | 39 | #include <asm/blackfin.h> |
41 | 40 | ||
@@ -92,8 +91,7 @@ static char *cplb_print_entry(char *buf, int type) | |||
92 | } else | 91 | } else |
93 | buf += sprintf(buf, "Data CPLB entry:\n"); | 92 | buf += sprintf(buf, "Data CPLB entry:\n"); |
94 | 93 | ||
95 | buf += sprintf(buf, "Address\t\tData\tSize\tValid\tLocked\tSwapin\ | 94 | buf += sprintf(buf, "Address\t\tData\tSize\tValid\tLocked\tSwapin\n\tiCount\toCount\n"); |
96 | \tiCount\toCount\n"); | ||
97 | 95 | ||
98 | while (*p_addr != 0xffffffff) { | 96 | while (*p_addr != 0xffffffff) { |
99 | entry = cplb_find_entry(cplb_addr, cplb_data, *p_addr, *p_data); | 97 | entry = cplb_find_entry(cplb_addr, cplb_data, *p_addr, *p_data); |
@@ -144,8 +142,7 @@ static int cplbinfo_proc_output(char *buf) | |||
144 | 142 | ||
145 | p = buf; | 143 | p = buf; |
146 | 144 | ||
147 | p += sprintf(p, | 145 | p += sprintf(p, "------------------ CPLB Information ------------------\n\n"); |
148 | "------------------ CPLB Information ------------------\n\n"); | ||
149 | 146 | ||
150 | if (bfin_read_IMEM_CONTROL() & ENICPLB) | 147 | if (bfin_read_IMEM_CONTROL() & ENICPLB) |
151 | p = cplb_print_entry(p, CPLB_I); | 148 | p = cplb_print_entry(p, CPLB_I); |
@@ -191,9 +188,9 @@ static int __init cplbinfo_init(void) | |||
191 | { | 188 | { |
192 | struct proc_dir_entry *entry; | 189 | struct proc_dir_entry *entry; |
193 | 190 | ||
194 | if ((entry = create_proc_entry("cplbinfo", 0, NULL)) == NULL) { | 191 | entry = create_proc_entry("cplbinfo", 0, NULL); |
192 | if (!entry) | ||
195 | return -ENOMEM; | 193 | return -ENOMEM; |
196 | } | ||
197 | 194 | ||
198 | entry->read_proc = cplbinfo_read_proc; | 195 | entry->read_proc = cplbinfo_read_proc; |
199 | entry->write_proc = cplbinfo_write_proc; | 196 | entry->write_proc = cplbinfo_write_proc; |
diff --git a/arch/blackfin/mach-common/entry.S b/arch/blackfin/mach-common/entry.S index 15603275f74..fa4e6336317 100644 --- a/arch/blackfin/mach-common/entry.S +++ b/arch/blackfin/mach-common/entry.S | |||
@@ -49,8 +49,8 @@ | |||
49 | 49 | ||
50 | 50 | ||
51 | #include <linux/linkage.h> | 51 | #include <linux/linkage.h> |
52 | #include <linux/unistd.h> | ||
52 | #include <asm/blackfin.h> | 53 | #include <asm/blackfin.h> |
53 | #include <asm/unistd.h> | ||
54 | #include <asm/errno.h> | 54 | #include <asm/errno.h> |
55 | #include <asm/thread_info.h> /* TIF_NEED_RESCHED */ | 55 | #include <asm/thread_info.h> /* TIF_NEED_RESCHED */ |
56 | #include <asm/asm-offsets.h> | 56 | #include <asm/asm-offsets.h> |
diff --git a/arch/blackfin/mach-common/ints-priority-dc.c b/arch/blackfin/mach-common/ints-priority-dc.c index e6511db2403..ceb61d95d44 100644 --- a/arch/blackfin/mach-common/ints-priority-dc.c +++ b/arch/blackfin/mach-common/ints-priority-dc.c | |||
@@ -183,7 +183,7 @@ static void bf561_gpio_ack_irq(unsigned int irq) | |||
183 | { | 183 | { |
184 | u16 gpionr = irq - IRQ_PF0; | 184 | u16 gpionr = irq - IRQ_PF0; |
185 | 185 | ||
186 | if(gpio_edge_triggered[gpio_bank(gpionr)] & gpio_bit(gpionr)) { | 186 | if (gpio_edge_triggered[gpio_bank(gpionr)] & gpio_bit(gpionr)) { |
187 | set_gpio_data(gpionr, 0); | 187 | set_gpio_data(gpionr, 0); |
188 | SSYNC(); | 188 | SSYNC(); |
189 | } | 189 | } |
@@ -193,7 +193,7 @@ static void bf561_gpio_mask_ack_irq(unsigned int irq) | |||
193 | { | 193 | { |
194 | u16 gpionr = irq - IRQ_PF0; | 194 | u16 gpionr = irq - IRQ_PF0; |
195 | 195 | ||
196 | if(gpio_edge_triggered[gpio_bank(gpionr)] & gpio_bit(gpionr)) { | 196 | if (gpio_edge_triggered[gpio_bank(gpionr)] & gpio_bit(gpionr)) { |
197 | set_gpio_data(gpionr, 0); | 197 | set_gpio_data(gpionr, 0); |
198 | SSYNC(); | 198 | SSYNC(); |
199 | } | 199 | } |
@@ -222,7 +222,7 @@ static unsigned int bf561_gpio_irq_startup(unsigned int irq) | |||
222 | if (!(gpio_enabled[gpio_bank(gpionr)] & gpio_bit(gpionr))) { | 222 | if (!(gpio_enabled[gpio_bank(gpionr)] & gpio_bit(gpionr))) { |
223 | 223 | ||
224 | ret = gpio_request(gpionr, NULL); | 224 | ret = gpio_request(gpionr, NULL); |
225 | if(ret) | 225 | if (ret) |
226 | return ret; | 226 | return ret; |
227 | 227 | ||
228 | } | 228 | } |
@@ -262,7 +262,7 @@ static int bf561_gpio_irq_type(unsigned int irq, unsigned int type) | |||
262 | if (!(gpio_enabled[gpio_bank(gpionr)] & gpio_bit(gpionr))) { | 262 | if (!(gpio_enabled[gpio_bank(gpionr)] & gpio_bit(gpionr))) { |
263 | 263 | ||
264 | ret = gpio_request(gpionr, NULL); | 264 | ret = gpio_request(gpionr, NULL); |
265 | if(ret) | 265 | if (ret) |
266 | return ret; | 266 | return ret; |
267 | 267 | ||
268 | } | 268 | } |
diff --git a/arch/blackfin/mach-common/ints-priority-sc.c b/arch/blackfin/mach-common/ints-priority-sc.c index 27838da55d6..9f962f9df08 100644 --- a/arch/blackfin/mach-common/ints-priority-sc.c +++ b/arch/blackfin/mach-common/ints-priority-sc.c | |||
@@ -146,8 +146,8 @@ static void bfin_internal_mask_irq(unsigned int irq) | |||
146 | ~(1 << (irq - (IRQ_CORETMR + 1)))); | 146 | ~(1 << (irq - (IRQ_CORETMR + 1)))); |
147 | #else | 147 | #else |
148 | unsigned mask_bank, mask_bit; | 148 | unsigned mask_bank, mask_bit; |
149 | mask_bank = (irq - (IRQ_CORETMR +1))/32; | 149 | mask_bank = (irq - (IRQ_CORETMR + 1)) / 32; |
150 | mask_bit = (irq - (IRQ_CORETMR + 1))%32; | 150 | mask_bit = (irq - (IRQ_CORETMR + 1)) % 32; |
151 | bfin_write_SIC_IMASK( mask_bank, bfin_read_SIC_IMASK(mask_bank) & \ | 151 | bfin_write_SIC_IMASK( mask_bank, bfin_read_SIC_IMASK(mask_bank) & \ |
152 | ~(1 << mask_bit)); | 152 | ~(1 << mask_bit)); |
153 | #endif | 153 | #endif |
@@ -161,7 +161,7 @@ static void bfin_internal_unmask_irq(unsigned int irq) | |||
161 | (1 << (irq - (IRQ_CORETMR + 1)))); | 161 | (1 << (irq - (IRQ_CORETMR + 1)))); |
162 | #else | 162 | #else |
163 | unsigned mask_bank, mask_bit; | 163 | unsigned mask_bank, mask_bit; |
164 | mask_bank = (irq - (IRQ_CORETMR +1))/32; | 164 | mask_bank = (irq - (IRQ_CORETMR + 1)) / 32; |
165 | mask_bit = (irq - (IRQ_CORETMR + 1))%32; | 165 | mask_bit = (irq - (IRQ_CORETMR + 1))%32; |
166 | bfin_write_SIC_IMASK(mask_bank, bfin_read_SIC_IMASK(mask_bank) | \ | 166 | bfin_write_SIC_IMASK(mask_bank, bfin_read_SIC_IMASK(mask_bank) | \ |
167 | ( 1 << mask_bit)); | 167 | ( 1 << mask_bit)); |
@@ -439,7 +439,7 @@ static void bfin_demux_gpio_irq(unsigned int intb_irq, | |||
439 | { | 439 | { |
440 | u16 i; | 440 | u16 i; |
441 | 441 | ||
442 | for (i = 0; i < MAX_BLACKFIN_GPIOS; i+=16) { | 442 | for (i = 0; i < MAX_BLACKFIN_GPIOS; i += 16) { |
443 | int irq = IRQ_PF0 + i; | 443 | int irq = IRQ_PF0 + i; |
444 | int flag_d = get_gpiop_data(i); | 444 | int flag_d = get_gpiop_data(i); |
445 | int mask = | 445 | int mask = |
@@ -590,7 +590,7 @@ void do_irq(int vec, struct pt_regs *fp) | |||
590 | sic_status[1] = bfin_read_SIC_ISR(1) & bfin_read_SIC_IMASK(1); | 590 | sic_status[1] = bfin_read_SIC_ISR(1) & bfin_read_SIC_IMASK(1); |
591 | sic_status[2] = bfin_read_SIC_ISR(2) & bfin_read_SIC_IMASK(2); | 591 | sic_status[2] = bfin_read_SIC_ISR(2) & bfin_read_SIC_IMASK(2); |
592 | SSYNC(); | 592 | SSYNC(); |
593 | for(;; ivg++) { | 593 | for (;; ivg++) { |
594 | if (ivg >= ivg_stop) { | 594 | if (ivg >= ivg_stop) { |
595 | atomic_inc(&num_spurious); | 595 | atomic_inc(&num_spurious); |
596 | return; | 596 | return; |
diff --git a/arch/blackfin/mach-common/pm.c b/arch/blackfin/mach-common/pm.c index 150ef5d088d..1772d8d2c1a 100644 --- a/arch/blackfin/mach-common/pm.c +++ b/arch/blackfin/mach-common/pm.c | |||
@@ -35,10 +35,10 @@ | |||
35 | #include <linux/pm.h> | 35 | #include <linux/pm.h> |
36 | #include <linux/sched.h> | 36 | #include <linux/sched.h> |
37 | #include <linux/proc_fs.h> | 37 | #include <linux/proc_fs.h> |
38 | #include <linux/io.h> | ||
39 | #include <linux/irq.h> | ||
38 | 40 | ||
39 | #include <asm/io.h> | ||
40 | #include <asm/dpmc.h> | 41 | #include <asm/dpmc.h> |
41 | #include <asm/irq.h> | ||
42 | #include <asm/gpio.h> | 42 | #include <asm/gpio.h> |
43 | 43 | ||
44 | #ifdef CONFIG_PM_WAKEUP_GPIO_POLAR_H | 44 | #ifdef CONFIG_PM_WAKEUP_GPIO_POLAR_H |