OMAP clock/hwmod: fix off-by-one errors

Fix loop bailout off-by-one bugs reported by Juha Leppänen
<juha_motorsportcom@luukku.com>.

This second version incorporates comments from Russell King
<linux@arm.linux.org.uk>.  A new macro, 'omap_test_timeout', has
been created, with cleaner code, and existing code has been converted
to use it.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Juha Leppänen <juha_motorsportcom@luukku.com>
Cc: Russell King <linux@arm.linux.org.uk>

1 files changed, 5 insertions, 8 deletions

diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 633b216a8b2..7aaf5f1eea7 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -45,6 +45,7 @@
 #include <linux/mutex.h>
 #include <linux/bootmem.h>
 
+#include <plat/common.h>
 #include <plat/cpu.h>
 #include <plat/clockdomain.h>
 #include <plat/powerdomain.h>
@@ -736,7 +737,7 @@ static int _wait_target_ready(struct omap_hwmod *oh)
 static int _reset(struct omap_hwmod *oh)
 {
         u32 r, v;
-        int c;
+        int c = 0;
 
         if (!oh->sysconfig ||
             !(oh->sysconfig->sysc_flags & SYSC_HAS_SOFTRESET) ||
@@ -758,13 +759,9 @@ static int _reset(struct omap_hwmod *oh)
                 return r;
         _write_sysconfig(v, oh);
 
-        c = 0;
-        while (c < MAX_MODULE_RESET_WAIT &&
-               !(omap_hwmod_readl(oh, oh->sysconfig->syss_offs) &
-                 SYSS_RESETDONE_MASK)) {
-                udelay(1);
-                c++;
-        }
+        omap_test_timeout((omap_hwmod_readl(oh, oh->sysconfig->syss_offs) &
+                           SYSS_RESETDONE_MASK),
+                          MAX_MODULE_RESET_WAIT, c);
 
         if (c == MAX_MODULE_RESET_WAIT)
                 WARN(1, "omap_hwmod: %s: failed to reset in %d usec\n",