ARM: OMAP: switch to gpio_direction_output

More conversion to the standard GPIO interfaces:  stop using
omap_set_gpio_direction() entirely, and switch over to the
gpio_direction_output() call.

Note that because gpio_direction_output() includes the initial
value, this change isn't quite transparent.

 - For the call sites which defined an initial value either
   before or after setting the direction, that value was used.

   When that value was previously assigned afterwards, this
   could eliminate a brief output glitch ... and possibly
   change behavior.  In a few cases (LCDs) several values
   were assigned together ... those were re-arranged to match
   the explicit sequence provided.

 - Some call sites didn't define such a value; so I chose an
   initial "off/reset" value that seemed to default to "off".

In short, files touched by this patch might notice some small
changes in startup behavior (with trivial fixes).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>

1 files changed, 3 insertions, 8 deletions

diff --git a/arch/arm/mach-omap1/board-sx1.c b/arch/arm/mach-omap1/board-sx1.c
index 22305270381..93bd395b997 100644
--- a/arch/arm/mach-omap1/board-sx1.c
+++ b/arch/arm/mach-omap1/board-sx1.c
@@ -436,14 +436,9 @@ static void __init omap_sx1_init(void)
         omap_request_gpio(1);   /* A_IRDA_OFF */
         omap_request_gpio(11);  /* A_SWITCH */
         omap_request_gpio(15);  /* A_USB_ON */
-        omap_set_gpio_direction(1, 0);/* gpio1 -> output */
-        omap_set_gpio_direction(11, 0);/* gpio11 -> output */
-        omap_set_gpio_direction(15, 0);/* gpio15 -> output */
-        /* set GPIO data */
-        gpio_set_value(1, 1);/*A_IRDA_OFF = 1 */
-        gpio_set_value(11, 0);/*A_SWITCH = 0 */
-        gpio_set_value(15, 0);/*A_USB_ON = 0 */
-
+        gpio_direction_output(1, 1);    /*A_IRDA_OFF = 1 */
+        gpio_direction_output(11, 0);   /*A_SWITCH = 0 */
+        gpio_direction_output(15, 0);   /*A_USB_ON = 0 */
 }
 /*----------------------------------------*/
 static void __init omap_sx1_init_irq(void)